Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: improved readability of emoji in sync logs #572

Merged
merged 2 commits into from
Aug 17, 2023

Conversation

yisibl
Copy link
Contributor

@yisibl yisibl commented Aug 17, 2023

No description provided.

Copy link
Member

@fengmk2 fengmk2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fengmk2 fengmk2 added the enhancement New feature or request label Aug 17, 2023
@@ -885,9 +885,9 @@ export class PackageSyncerService extends AbstractService {

// clean cache
await this.cacheService.removeCache(fullname);
logs.push(`[${isoNow()}] 🟢 Clean cache`);
logs.push(`[${isoNow()}] 🟢 log: ${logUrl}`);
logs.push(`[${isoNow()}] 🟢🟢🟢🟢🟢 ${url} 🟢🟢🟢🟢🟢`);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@yisibl 果然,单测 assert 也一起修改一下

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

好嘞,测试更新了

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #572 (6fc9671) into master (ab2fde7) will decrease coverage by 0.04%.
Report is 28 commits behind head on master.
The diff coverage is 97.48%.

@@            Coverage Diff             @@
##           master     #572      +/-   ##
==========================================
- Coverage   97.02%   96.99%   -0.04%     
==========================================
  Files         174      175       +1     
  Lines       16588    16753     +165     
  Branches     2177     2200      +23     
==========================================
+ Hits        16095    16249     +154     
- Misses        493      504      +11     
Files Changed Coverage Δ
app/port/webauth/WebauthController.ts 85.59% <78.94%> (+0.53%) ⬆️
app/common/PackageUtil.ts 97.61% <90.90%> (-1.42%) ⬇️
app/core/service/PackageSyncerService.ts 98.21% <91.66%> (-0.01%) ⬇️
app/common/FileUtil.ts 100.00% <100.00%> (ø)
app/common/UserUtil.ts 100.00% <100.00%> (ø)
app/common/adapter/CacheAdapter.ts 100.00% <100.00%> (ø)
app/common/adapter/NPMRegistry.ts 100.00% <100.00%> (ø)
app/common/adapter/binary/AbstractBinary.ts 94.17% <100.00%> (+0.11%) ⬆️
app/common/adapter/binary/NodePreGypBinary.ts 98.69% <100.00%> (+<0.01%) ⬆️
app/common/adapter/binary/PlaywrightBinary.ts 99.26% <100.00%> (+0.03%) ⬆️
... and 30 more

... and 2 files with indirect coverage changes

@fengmk2 fengmk2 merged commit 0ac275a into cnpm:master Aug 17, 2023
6 of 8 checks passed
fengmk2 pushed a commit that referenced this pull request Aug 17, 2023
[skip ci]

## [3.41.0](v3.40.0...v3.41.0) (2023-08-17)

### Features

* improved readability of emoji in sync logs ([#572](#572)) ([0ac275a](0ac275a))
@yisibl yisibl deleted the new-log-emoji branch September 19, 2024 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants