-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: improved readability of emoji in sync logs #572
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@@ -885,9 +885,9 @@ export class PackageSyncerService extends AbstractService { | |||
|
|||
// clean cache | |||
await this.cacheService.removeCache(fullname); | |||
logs.push(`[${isoNow()}] 🟢 Clean cache`); | |||
logs.push(`[${isoNow()}] 🟢 log: ${logUrl}`); | |||
logs.push(`[${isoNow()}] 🟢🟢🟢🟢🟢 ${url} 🟢🟢🟢🟢🟢`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@yisibl 果然,单测 assert 也一起修改一下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
好嘞,测试更新了
Codecov Report
@@ Coverage Diff @@
## master #572 +/- ##
==========================================
- Coverage 97.02% 96.99% -0.04%
==========================================
Files 174 175 +1
Lines 16588 16753 +165
Branches 2177 2200 +23
==========================================
+ Hits 16095 16249 +154
- Misses 493 504 +11
|
[skip ci] ## [3.41.0](v3.40.0...v3.41.0) (2023-08-17) ### Features * improved readability of emoji in sync logs ([#572](#572)) ([0ac275a](0ac275a))
No description provided.