Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Leftover bool chooseBestCrossCollapse(...) fails to compile due to missing return #210

Open
StefanBruens opened this issue Jan 22, 2023 · 0 comments

Comments

@StefanBruens
Copy link

The function is apparently not used.

The return was removed with f2ba3e9

[  628s] /home/abuild/rpmbuild/BUILD/meshlab-MeshLab-2022.02/src/vcglib/vcg/complex/algorithms/isotropic_remeshing.h: In static member function 'static bool vcg::tri::IsotropicRemeshing<TRI_MESH_TYPE>::chooseBestCrossCollapse(PosType&, VertexPair&, std::vector<typename CleanMeshType::FaceType*>&)':
[  628s] /home/abuild/rpmbuild/BUILD/meshlab-MeshLab-2022.02/src/vcglib/vcg/complex/algorithms/isotropic_remeshing.h:1089:5: error: no return statement in function returning non-void [-Werror=return-type]
[  628s]  1089 |     }
[  628s]       |     ^

static bool chooseBestCrossCollapse(PosType &p, VertexPair& bp, std::vector<FaceType*> &ff)
{

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant