Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test: Verify if secrets are encrypted #1971

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

haskojur
Copy link
Contributor

@haskojur haskojur commented Apr 15, 2024

Description

By default in kubernetes system, encrypting of data inside object like secret is not enabled, so data in etcd are available for potential attacker.
Encrypting of secret is possible in newer versions of kubernetes. When this configuration is done, all newly created secrets has encrypted data in etcd key-value store.
We can use kubescape test to cover this area.

Issues:

Refs: #1970

How has this been tested:

  • Covered by existing integration testing
  • Added integration testing to cover
  • Verified all A/C passes
    • develop
    • master
    • tag/other branch
  • Test environment
    • Shared Packet K8s cluster
    • New Packet K8s cluster
    • Kind cluster
  • Have not tested

Types of changes:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

Checklist:

Documentation

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • No updates required.

Code Review

  • Does the test handle fatal exceptions, ie. rescue block

Issue

  • Tasks in issue are checked off

@agentpoyo
Copy link
Collaborator

Please create WIP or DRAFT PRs as DRAFT's when creating, this will prevent any accidental merges as "Draft" status will grey out the "merge" button until they're actually ready for review and merging.

@haskojur haskojur marked this pull request as draft April 17, 2024 06:34
@haskojur haskojur marked this pull request as ready for review April 19, 2024 13:23
@haskojur haskojur changed the title (WIP) Test: Verify if secrets are encrypted Test: Verify if secrets are encrypted Apr 19, 2024
src/tasks/utils/utils.cr Outdated Show resolved Hide resolved
src/tasks/utils/utils.cr Outdated Show resolved Hide resolved
src/tasks/utils/utils.cr Outdated Show resolved Hide resolved
Copy link
Collaborator

@taylor taylor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@haskojur haskojur requested a review from HashNuke as a code owner April 24, 2024 12:03
@haskojur
Copy link
Contributor Author

haskojur commented May 3, 2024

@HashNuke I think this one is ready for test

@martin-mat martin-mat requested review from martin-mat and removed request for ptacemic May 14, 2024 13:42
Copy link
Collaborator

@martin-mat martin-mat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

spec test(s) missing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants