configmap: CNF Installation (5.2) Remove installation configmap #2164
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kosstennbl
force-pushed
the
#2153-remove-installation-configmap
branch
from
9fcd974
to
fd7a29d
Compare
Refs: #2095 - In attempt to set up a different CNF the user gets a warning and is blocked from proceeding. - There were some changes necessary in the ran_spec.cr tests to forego using two cnf_setups (auxiliary function was created to deploy 5g through helm instead). This should be changed in the future when cnf_manager.cr is rehauled. - This change also removes two spec tests that were considered unnecessary/non-conformant with the new approach to only having a single CNF set up at any given time. - Spec test to verify functionality was added.
- group manifests from several CNFs into one common_manifests.yaml file - add functionality in cleanup.cr to remove this file - depends on PR in helm library: cnf-testsuite/helm#4 - common_manifest functionality: used common_manifest instead of templates - remove methods related to templates - update generated manifest: add namespace to each resource Signed-off-by: barmull <[email protected]>
Installation configmap can significantly complicate new installation process and has multiple issues with its design (and related tests). Remove installation congigmap Redesign related tests or make them always skip until further redesign would be done in the scope of different change Refs: #2153 Signed-off-by: Konstantin Yarovoy <[email protected]>
kosstennbl
force-pushed
the
#2153-remove-installation-configmap
branch
from
fd7a29d
to
db403ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Installation configmap can significantly complicate new installation
process and has multiple issues with its design (and related tests).
Remove installation congigmap
Redesign related tests or make them always skip until further
redesign would be done in the scope of different change
Issues:
Refs: #2153