fix(api): validate that url must be a valid url with http or https (#19)

cnumr · Dec 8, 2023 · 9141d1c · 9141d1c
1 parent 54fb84a
commit 9141d1c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 0 deletions.
diff --git a/components/ecoindex/models/compute.py b/components/ecoindex/models/compute.py
@@ -103,6 +103,7 @@ class WebPage(BaseModel):
     @classmethod
     def url_as_http_url(cls, v: str) -> str:
         url_object = AnyHttpUrl(url=v)
+        assert url_object.scheme in {"http", "https"}, "scheme must be http or https"
 
         return url_object.unicode_string()
 

diff --git a/test/components/ecoindex/compute/test_models.py b/test/components/ecoindex/compute/test_models.py
@@ -28,6 +28,9 @@ def test_model_webpage_invalid_url() -> None:
         "[type=url_parsing, input_value='toto', input_type=str]\n"
     ) in str(error.value)
 
+    with raises(ValidationError):
+        WebPage(url="about:config")
+
 
 def test_model_webpage_wrong_size() -> None:
     with raises(ValidationError) as error: