DistributionRequirement enhancements #1403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your contribution! Reviewing pull requests take really a lot of time and we're all volunteers. Please make sure you go through the following check list and complete them all before pinging someone for a review.
As you learn things over your Pull Request please help others on the chat and on PRs to get their stuff right as well! |
|
ack a1a54c7 |
|
ack 8f6c2dd |
|
ack a1a0a0d |
bears/ruby/RubySyntaxBear.py
Outdated
| @@ -14,7 +16,8 @@ class RubySyntaxBear: | |||
| Checks the code with ``ruby -wc`` on each file separately. | |||
| """ | |||
| LANGUAGES = {'Ruby'} | |||
| REQUIREMENTS = {GemRequirement('ruby', '2.1.5')} | |||
| REQUIREMENTS = {GemRequirement('ruby', '2.1.5'), | |||
There was a problem hiding this comment.
hm, does it need the gem requirement ruby too then?
There was a problem hiding this comment.
You're asking me ... ? You added it :P da62953
But yes, I think this GemRequirement needs to be revisited, and I'd be happy to remove it as redundant, but maybe you had some reason why the 2.1.5 is there...? (did they really only add -wc to ruby in that version?
There was a problem hiding this comment.
i mostly copy pasted what we had in the gemfiles :) it is probably at that point that i found it relevant, and now since youre adding the system ruby, im asking if we still need the gem ruby :-??
|
ack 28fef97 |
Adrianzatreanu
changed the title
|
ack 8b76bb6 |
jayvdb
force-pushed
the
req-tidy
branch
2 times, most recently
from
3e0d973 to
cb0dc2c
Compare
jayvdb
changed the title
|
@Adrianzatreanu , cb0dc2c is revised and ready for review, then this can be merged. |
|
There isnt a package called 'java' in Ubuntu. It is |
|
ack 0607d90 |
|
ack 66b59c1 |
|
ack 63dc358 |
|
please rebase :D |
|
@rultor merge |
@jayvdb Oops, I failed. You can see the full log here (spent 1min) |
The linter is part of libxml2-utils, and is not included in the libxml2 package.
apt package libperl-critic-perl depends on perl, so the latter does not need to also be stated as a separate dependency.
PHPLintBear only depends on the php executable.
RubySyntaxBear only depends on the ruby executable. Removes 'ruby' from Gemfile, added in 35c242b.
ScalaLintBear only requires java.
CheckstyleBear currently only requires java.
|
@rultor merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE.~~This should be merged after #1386 ~~
(1386 is going to take a while, and we need these in to assist with understanding needed Requirements)