PyLintBear: ignore PyLint rules individually #1475
Conversation
bears/python/PyLintBear.py
Outdated
| @@ -32,7 +32,7 @@ class PyLintBear: | |||
|
|
|||
| @staticmethod | |||
| def create_arguments(filename, file, config_file, | |||
| pylint_disable: typed_list(str)=None, | |||
| pylint_disable: typed_list(str)='', | |||
There was a problem hiding this comment.
Line contains following spacing inconsistencies:
- Trailing whitespaces.
SpaceConsistencyBear, severity NORMAL, section python.
The issue can be fixed by applying the following patch:
--- a/bears/python/PyLintBear.py
+++ b/bears/python/PyLintBear.py
@@ -32,7 +32,7 @@
@staticmethod
def create_arguments(filename, file, config_file,
- pylint_disable: typed_list(str)='',
+ pylint_disable: typed_list(str)='',
pylint_enable: typed_list(str)=None,
pylint_cli_options: str='',
pylint_rcfile: str=''):
bears/python/PyLintBear.py
Outdated
| @@ -32,7 +32,7 @@ class PyLintBear: | |||
|
|
|||
| @staticmethod | |||
| def create_arguments(filename, file, config_file, | |||
| pylint_disable: typed_list(str)=None, | |||
| pylint_disable: typed_list(str)='', | |||
There was a problem hiding this comment.
W291 trailing whitespace'
PycodestyleBear (W291), severity NORMAL, section autopep8.
bears/python/PyLintBear.py
Outdated
| @@ -32,7 +32,7 @@ class PyLintBear: | |||
|
|
|||
| @staticmethod | |||
| def create_arguments(filename, file, config_file, | |||
| pylint_disable: typed_list(str)=None, | |||
| pylint_disable: typed_list(str)='', | |||
There was a problem hiding this comment.
The code does not comply to PEP8.
PEP8Bear, severity NORMAL, section autopep8.
The issue can be fixed by applying the following patch:
--- a/bears/python/PyLintBear.py
+++ b/bears/python/PyLintBear.py
@@ -32,7 +32,7 @@
@staticmethod
def create_arguments(filename, file, config_file,
- pylint_disable: typed_list(str)='',
+ pylint_disable: typed_list(str)='',
pylint_enable: typed_list(str)=None,
pylint_cli_options: str='',
pylint_rcfile: str=''):
bears/python/PyLintBear.py
Outdated
| @@ -32,13 +32,13 @@ class PyLintBear: | |||
|
|
|||
| @staticmethod | |||
| def create_arguments(filename, file, config_file, | |||
| pylint_disable: typed_list(str)=None, | |||
| pylint_disable: typed_list(str)='', | |||
There was a problem hiding this comment.
Line is longer than allowed. (91 > 79)
LineLengthBear, severity NORMAL, section linelength.
bears/python/PyLintBear.py
Outdated
| @@ -32,13 +32,13 @@ class PyLintBear: | |||
|
|
|||
| @staticmethod | |||
| def create_arguments(filename, file, config_file, | |||
| pylint_disable: typed_list(str)=None, | |||
| pylint_disable: typed_list(str)='', | |||
There was a problem hiding this comment.
E501 line too long (91 > 79 characters)'
PycodestyleBear (E501), severity NORMAL, section autopep8.
|
Comment on 216a8b9. Shortlog of HEAD commit does not match given regex: ([^:]|[^:]+: [A-Z0-9].*) GitCommitBear, severity NORMAL, section |
bears/python/PyLintBear.py
Outdated
| @@ -32,7 +32,7 @@ class PyLintBear: | |||
|
|
|||
| @staticmethod | |||
| def create_arguments(filename, file, config_file, | |||
| pylint_disable: typed_list(str)=None, | |||
| pylint_disable: typed_list(str)='', | |||
There was a problem hiding this comment.
W291 trailing whitespace'
PycodestyleBear (W291), severity NORMAL, section autopep8.
bears/python/PyLintBear.py
Outdated
| @@ -32,7 +32,7 @@ class PyLintBear: | |||
|
|
|||
| @staticmethod | |||
| def create_arguments(filename, file, config_file, | |||
| pylint_disable: typed_list(str)=None, | |||
| pylint_disable: typed_list(str)='', | |||
There was a problem hiding this comment.
The code does not comply to PEP8.
PEP8Bear, severity NORMAL, section autopep8.
The issue can be fixed by applying the following patch:
--- a/bears/python/PyLintBear.py
+++ b/bears/python/PyLintBear.py
@@ -32,7 +32,7 @@
@staticmethod
def create_arguments(filename, file, config_file,
- pylint_disable: typed_list(str)='',
+ pylint_disable: typed_list(str)='',
pylint_enable: typed_list(str)=None,
pylint_cli_options: str='',
pylint_rcfile: str=''):
bears/python/PyLintBear.py
Outdated
| @@ -32,7 +32,7 @@ class PyLintBear: | |||
|
|
|||
| @staticmethod | |||
| def create_arguments(filename, file, config_file, | |||
| pylint_disable: typed_list(str)=None, | |||
| pylint_disable: typed_list(str)='', | |||
There was a problem hiding this comment.
Line contains following spacing inconsistencies:
- Trailing whitespaces.
SpaceConsistencyBear, severity NORMAL, section python.
The issue can be fixed by applying the following patch:
--- a/bears/python/PyLintBear.py
+++ b/bears/python/PyLintBear.py
@@ -32,7 +32,7 @@
@staticmethod
def create_arguments(filename, file, config_file,
- pylint_disable: typed_list(str)='',
+ pylint_disable: typed_list(str)='',
pylint_enable: typed_list(str)=None,
pylint_cli_options: str='',
pylint_rcfile: str=''):
bears/python/PyLintBear.py
Outdated
| @@ -32,13 +32,13 @@ class PyLintBear: | |||
|
|
|||
| @staticmethod | |||
| def create_arguments(filename, file, config_file, | |||
| pylint_disable: typed_list(str)=None, | |||
| pylint_disable: typed_list(str)='', | |||
There was a problem hiding this comment.
E501 line too long (91 > 79 characters)'
PycodestyleBear (E501), severity NORMAL, section autopep8.
bears/python/PyLintBear.py
Outdated
| @@ -32,13 +32,13 @@ class PyLintBear: | |||
|
|
|||
| @staticmethod | |||
| def create_arguments(filename, file, config_file, | |||
| pylint_disable: typed_list(str)=None, | |||
| pylint_disable: typed_list(str)='', | |||
There was a problem hiding this comment.
Line is longer than allowed. (91 > 79)
LineLengthBear, severity NORMAL, section linelength.
|
Comment on 216a8b9. Shortlog of HEAD commit does not match given regex: ([^:]|[^:]+: [A-Z0-9].*) GitCommitBear, severity NORMAL, section |
bears/python/PyLintBear.py
Outdated
| @@ -32,7 +32,7 @@ class PyLintBear: | |||
|
|
|||
| @staticmethod | |||
| def create_arguments(filename, file, config_file, | |||
| pylint_disable: typed_list(str)=None, | |||
| pylint_disable: typed_list(str)='', | |||
There was a problem hiding this comment.
Line contains following spacing inconsistencies:
- Trailing whitespaces.
SpaceConsistencyBear, severity NORMAL, section python.
The issue can be fixed by applying the following patch:
--- a/bears/python/PyLintBear.py
+++ b/bears/python/PyLintBear.py
@@ -32,7 +32,7 @@
@staticmethod
def create_arguments(filename, file, config_file,
- pylint_disable: typed_list(str)='',
+ pylint_disable: typed_list(str)='',
pylint_enable: typed_list(str)=None,
pylint_cli_options: str='',
pylint_rcfile: str=''):
bears/python/PyLintBear.py
Outdated
| @@ -32,7 +32,7 @@ class PyLintBear: | |||
|
|
|||
| @staticmethod | |||
| def create_arguments(filename, file, config_file, | |||
| pylint_disable: typed_list(str)=None, | |||
| pylint_disable: typed_list(str)='', | |||
There was a problem hiding this comment.
W291 trailing whitespace'
PycodestyleBear (W291), severity NORMAL, section autopep8.
bears/python/PyLintBear.py
Outdated
| @@ -32,7 +32,7 @@ class PyLintBear: | |||
|
|
|||
| @staticmethod | |||
| def create_arguments(filename, file, config_file, | |||
| pylint_disable: typed_list(str)=None, | |||
| pylint_disable: typed_list(str)='', | |||
There was a problem hiding this comment.
The code does not comply to PEP8.
PEP8Bear, severity NORMAL, section autopep8.
The issue can be fixed by applying the following patch:
--- a/bears/python/PyLintBear.py
+++ b/bears/python/PyLintBear.py
@@ -32,7 +32,7 @@
@staticmethod
def create_arguments(filename, file, config_file,
- pylint_disable: typed_list(str)='',
+ pylint_disable: typed_list(str)='',
pylint_enable: typed_list(str)=None,
pylint_cli_options: str='',
pylint_rcfile: str=''):
bears/python/PyLintBear.py
Outdated
| @@ -32,13 +32,13 @@ class PyLintBear: | |||
|
|
|||
| @staticmethod | |||
| def create_arguments(filename, file, config_file, | |||
| pylint_disable: typed_list(str)=None, | |||
| pylint_disable: typed_list(str)='', | |||
There was a problem hiding this comment.
Line is longer than allowed. (91 > 79)
LineLengthBear, severity NORMAL, section linelength.
bears/python/PyLintBear.py
Outdated
| @@ -32,13 +32,13 @@ class PyLintBear: | |||
|
|
|||
| @staticmethod | |||
| def create_arguments(filename, file, config_file, | |||
| pylint_disable: typed_list(str)=None, | |||
| pylint_disable: typed_list(str)='', | |||
There was a problem hiding this comment.
E501 line too long (91 > 79 characters)'
PycodestyleBear (E501), severity NORMAL, section autopep8.
bears/python/PyLintBear.py
Outdated
| @@ -32,7 +32,7 @@ class PyLintBear: | |||
|
|
|||
| @staticmethod | |||
| def create_arguments(filename, file, config_file, | |||
| pylint_disable: typed_list(str)=None, | |||
| pylint_disable: typed_list(str)='', | |||
There was a problem hiding this comment.
Line contains following spacing inconsistencies:
- Trailing whitespaces.
SpaceConsistencyBear, severity NORMAL, section python.
The issue can be fixed by applying the following patch:
--- a/bears/python/PyLintBear.py
+++ b/bears/python/PyLintBear.py
@@ -32,7 +32,7 @@
@staticmethod
def create_arguments(filename, file, config_file,
- pylint_disable: typed_list(str)='',
+ pylint_disable: typed_list(str)='',
pylint_enable: typed_list(str)=None,
pylint_cli_options: str='',
pylint_rcfile: str=''):
bears/python/PyLintBear.py
Outdated
| @@ -32,7 +32,7 @@ class PyLintBear: | |||
|
|
|||
| @staticmethod | |||
| def create_arguments(filename, file, config_file, | |||
| pylint_disable: typed_list(str)=None, | |||
| pylint_disable: typed_list(str)='', | |||
There was a problem hiding this comment.
W291 trailing whitespace'
PycodestyleBear (W291), severity NORMAL, section autopep8.
bears/python/PyLintBear.py
Outdated
| @@ -32,7 +32,7 @@ class PyLintBear: | |||
|
|
|||
| @staticmethod | |||
| def create_arguments(filename, file, config_file, | |||
| pylint_disable: typed_list(str)=None, | |||
| pylint_disable: typed_list(str)='', | |||
There was a problem hiding this comment.
The code does not comply to PEP8.
PEP8Bear, severity NORMAL, section autopep8.
The issue can be fixed by applying the following patch:
--- a/bears/python/PyLintBear.py
+++ b/bears/python/PyLintBear.py
@@ -32,7 +32,7 @@
@staticmethod
def create_arguments(filename, file, config_file,
- pylint_disable: typed_list(str)='',
+ pylint_disable: typed_list(str)='',
pylint_enable: typed_list(str)=None,
pylint_cli_options: str='',
pylint_rcfile: str=''):
| @@ -32,7 +32,7 @@ class PyLintBear: | |||
|
|
|||
| @staticmethod | |||
| def create_arguments(filename, file, config_file, | |||
| pylint_disable: typed_list(str)=None, | |||
There was a problem hiding this comment.
How this solves the problem?
| @@ -49,8 +49,6 @@ def create_arguments(filename, file, config_file, | |||
| '--msg-template="L{line}C{column}: {msg_id} - {msg}"') | |||
| if pylint_disable: | |||
| args += ('--disable=' + ','.join(pylint_disable),) | |||
| if pylint_enable: | |||
There was a problem hiding this comment.
I guess you should also change the tests.
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
22 similar comments
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
User can now input id for PyLint checker that they want to disable. Fixes #18
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
cobot mark wip <URL>to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!