WIP Modify IndentationBear and Add LineBreakBear #1528
Conversation
aptrishu
changed the title
|
Comment on 4219617. Shortlog of the HEAD commit contains 52 character(s). This is 2 character(s) longer than the limit (52 > 50). GitCommitBear, severity NORMAL, section |
bears/general/LineBreakBear.py
Outdated
| encapsulators[encapsulator], | ||
| annotation_dict))) | ||
| print(encaps_pos) | ||
| indent = indentation_width*" " if use_spaces else "\t" |
There was a problem hiding this comment.
You do not use the preferred quotation marks.
QuotesBear, severity NORMAL, section python.
The issue can be fixed by applying the following patch:
--- a/bears/general/LineBreakBear.py
+++ b/bears/general/LineBreakBear.py
@@ -76,7 +76,7 @@
encapsulators[encapsulator],
annotation_dict)))
print(encaps_pos)
- indent = indentation_width*" " if use_spaces else "\t"
+ indent = indentation_width*" " if use_spaces else '\t'
suggested_positions = self._find_breakable_encapsulators(
file,
bears/general/LineBreakBear.py
Outdated
| encapsulators[encapsulator], | ||
| annotation_dict))) | ||
| print(encaps_pos) | ||
| indent = indentation_width*" " if use_spaces else "\t" |
There was a problem hiding this comment.
You do not use the preferred quotation marks.
QuotesBear, severity NORMAL, section python.
The issue can be fixed by applying the following patch:
--- a/bears/general/LineBreakBear.py
+++ b/bears/general/LineBreakBear.py
@@ -76,7 +76,7 @@
encapsulators[encapsulator],
annotation_dict)))
print(encaps_pos)
- indent = indentation_width*" " if use_spaces else "\t"
+ indent = indentation_width*' ' if use_spaces else "\t"
suggested_positions = self._find_breakable_encapsulators(
file,
bears/general/LineBreakBear.py
Outdated
| """ | ||
| encapsulators = dict(LanguageDefinition( | ||
| language, | ||
| coalang_dir=coalang_dir)["encapsulators"]) |
There was a problem hiding this comment.
You do not use the preferred quotation marks.
QuotesBear, severity NORMAL, section python.
The issue can be fixed by applying the following patch:
--- a/bears/general/LineBreakBear.py
+++ b/bears/general/LineBreakBear.py
@@ -55,7 +55,7 @@
"""
encapsulators = dict(LanguageDefinition(
language,
- coalang_dir=coalang_dir)["encapsulators"])
+ coalang_dir=coalang_dir)['encapsulators'])
# Get all lines which are over max_line_length
line_length_bear = LineLengthBear(self.section, Queue())
tests/general/LineBreakBearTest.py
Outdated
| self.section.append(Setting('use_spaces', False)) | ||
| results = self.get_results(file) | ||
|
|
||
| self.assertEqual(changed_file, results[0].diffs["file"].modified) |
There was a problem hiding this comment.
You do not use the preferred quotation marks.
QuotesBear, severity NORMAL, section python.
The issue can be fixed by applying the following patch:
--- a/tests/general/LineBreakBearTest.py
+++ b/tests/general/LineBreakBearTest.py
@@ -71,4 +71,4 @@
self.section.append(Setting('use_spaces', False))
results = self.get_results(file)
- self.assertEqual(changed_file, results[0].diffs["file"].modified)
+ self.assertEqual(changed_file, results[0].diffs['file'].modified)
tests/general/LineBreakBearTest.py
Outdated
| file = "func(p1,(p2,p3,p4,p5))\n".splitlines(True) | ||
|
|
||
| changed_file = ("func(p1,(\n" | ||
| "\tp2,p3,p4,p5))\n").splitlines(True) |
There was a problem hiding this comment.
You do not use the preferred quotation marks.
QuotesBear, severity NORMAL, section python.
The issue can be fixed by applying the following patch:
--- a/tests/general/LineBreakBearTest.py
+++ b/tests/general/LineBreakBearTest.py
@@ -67,7 +67,7 @@
file = "func(p1,(p2,p3,p4,p5))\n".splitlines(True)
changed_file = ("func(p1,(\n"
- "\tp2,p3,p4,p5))\n").splitlines(True)
+ '\tp2,p3,p4,p5))\n').splitlines(True)
self.section.append(Setting('use_spaces', False))
results = self.get_results(file)
tests/general/LineBreakBearTest.py
Outdated
|
|
||
| file = "func(p1,(p2,p3,p4,p5))\n".splitlines(True) | ||
|
|
||
| changed_file = ("func(p1,(\n" |
There was a problem hiding this comment.
You do not use the preferred quotation marks.
QuotesBear, severity NORMAL, section python.
The issue can be fixed by applying the following patch:
--- a/tests/general/LineBreakBearTest.py
+++ b/tests/general/LineBreakBearTest.py
@@ -66,7 +66,7 @@
file = "func(p1,(p2,p3,p4,p5))\n".splitlines(True)
- changed_file = ("func(p1,(\n"
+ changed_file = ('func(p1,(\n'
"\tp2,p3,p4,p5))\n").splitlines(True)
self.section.append(Setting('use_spaces', False))
results = self.get_results(file)
tests/general/LineBreakBearTest.py
Outdated
|
|
||
| def test_settings(self): | ||
|
|
||
| file = "func(p1,(p2,p3,p4,p5))\n".splitlines(True) |
There was a problem hiding this comment.
You do not use the preferred quotation marks.
QuotesBear, severity NORMAL, section python.
The issue can be fixed by applying the following patch:
--- a/tests/general/LineBreakBearTest.py
+++ b/tests/general/LineBreakBearTest.py
@@ -64,7 +64,7 @@
def test_settings(self):
- file = "func(p1,(p2,p3,p4,p5))\n".splitlines(True)
+ file = 'func(p1,(p2,p3,p4,p5))\n'.splitlines(True)
changed_file = ("func(p1,(\n"
"\tp2,p3,p4,p5))\n").splitlines(True)
tests/general/LineBreakBearTest.py
Outdated
| changed_file = ("func(p1,[\n" | ||
| " p2,p3,p4,p5])\n").splitlines(True) | ||
| results = self.get_results(file) | ||
| self.assertEqual(changed_file, results[0].diffs["file"].modified) |
There was a problem hiding this comment.
You do not use the preferred quotation marks.
QuotesBear, severity NORMAL, section python.
The issue can be fixed by applying the following patch:
--- a/tests/general/LineBreakBearTest.py
+++ b/tests/general/LineBreakBearTest.py
@@ -60,7 +60,7 @@
changed_file = ("func(p1,[\n"
" p2,p3,p4,p5])\n").splitlines(True)
results = self.get_results(file)
- self.assertEqual(changed_file, results[0].diffs["file"].modified)
+ self.assertEqual(changed_file, results[0].diffs['file'].modified)
def test_settings(self):
tests/general/LineBreakBearTest.py
Outdated
| # Test different types of encapsulators | ||
| file = "func(p1,[p2,p3,p4,p5])\n".splitlines(True) | ||
| changed_file = ("func(p1,[\n" | ||
| " p2,p3,p4,p5])\n").splitlines(True) |
There was a problem hiding this comment.
You do not use the preferred quotation marks.
QuotesBear, severity NORMAL, section python.
The issue can be fixed by applying the following patch:
--- a/tests/general/LineBreakBearTest.py
+++ b/tests/general/LineBreakBearTest.py
@@ -58,7 +58,7 @@
# Test different types of encapsulators
file = "func(p1,[p2,p3,p4,p5])\n".splitlines(True)
changed_file = ("func(p1,[\n"
- " p2,p3,p4,p5])\n").splitlines(True)
+ ' p2,p3,p4,p5])\n').splitlines(True)
results = self.get_results(file)
self.assertEqual(changed_file, results[0].diffs["file"].modified)
tests/general/LineBreakBearTest.py
Outdated
|
|
||
| # Test different types of encapsulators | ||
| file = "func(p1,[p2,p3,p4,p5])\n".splitlines(True) | ||
| changed_file = ("func(p1,[\n" |
There was a problem hiding this comment.
You do not use the preferred quotation marks.
QuotesBear, severity NORMAL, section python.
The issue can be fixed by applying the following patch:
--- a/tests/general/LineBreakBearTest.py
+++ b/tests/general/LineBreakBearTest.py
@@ -57,7 +57,7 @@
# Test different types of encapsulators
file = "func(p1,[p2,p3,p4,p5])\n".splitlines(True)
- changed_file = ("func(p1,[\n"
+ changed_file = ('func(p1,[\n'
" p2,p3,p4,p5])\n").splitlines(True)
results = self.get_results(file)
self.assertEqual(changed_file, results[0].diffs["file"].modified)
tests/general/LineBreakBearTest.py
Outdated
| self.assertEqual(results, []) | ||
|
|
||
| # Test different types of encapsulators | ||
| file = "func(p1,[p2,p3,p4,p5])\n".splitlines(True) |
There was a problem hiding this comment.
You do not use the preferred quotation marks.
QuotesBear, severity NORMAL, section python.
The issue can be fixed by applying the following patch:
--- a/tests/general/LineBreakBearTest.py
+++ b/tests/general/LineBreakBearTest.py
@@ -56,7 +56,7 @@
self.assertEqual(results, [])
# Test different types of encapsulators
- file = "func(p1,[p2,p3,p4,p5])\n".splitlines(True)
+ file = 'func(p1,[p2,p3,p4,p5])\n'.splitlines(True)
changed_file = ("func(p1,[\n"
" p2,p3,p4,p5])\n").splitlines(True)
results = self.get_results(file)
tests/general/LineBreakBearTest.py
Outdated
| self.assertEqual(changed_file, results[0].diffs["file"].modified) | ||
|
|
||
| # Testing encapsulator after max_line_length | ||
| file = "very_very_long_func(p1)\n".splitlines(True) |
There was a problem hiding this comment.
You do not use the preferred quotation marks.
QuotesBear, severity NORMAL, section python.
The issue can be fixed by applying the following patch:
--- a/tests/general/LineBreakBearTest.py
+++ b/tests/general/LineBreakBearTest.py
@@ -51,7 +51,7 @@
self.assertEqual(changed_file, results[0].diffs["file"].modified)
# Testing encapsulator after max_line_length
- file = "very_very_long_func(p1)\n".splitlines(True)
+ file = 'very_very_long_func(p1)\n'.splitlines(True)
results = self.get_results(file)
self.assertEqual(results, [])
tests/general/LineBreakBearTest.py
Outdated
| " p2,p3,p4,p5))\n").splitlines(True) | ||
| results = self.get_results(file) | ||
|
|
||
| self.assertEqual(changed_file, results[0].diffs["file"].modified) |
There was a problem hiding this comment.
You do not use the preferred quotation marks.
QuotesBear, severity NORMAL, section python.
The issue can be fixed by applying the following patch:
--- a/tests/general/LineBreakBearTest.py
+++ b/tests/general/LineBreakBearTest.py
@@ -48,7 +48,7 @@
" p2,p3,p4,p5))\n").splitlines(True)
results = self.get_results(file)
- self.assertEqual(changed_file, results[0].diffs["file"].modified)
+ self.assertEqual(changed_file, results[0].diffs['file'].modified)
# Testing encapsulator after max_line_length
file = "very_very_long_func(p1)\n".splitlines(True)
tests/general/LineBreakBearTest.py
Outdated
| file = "func(p1,(p2,p3,p4,p5))\n".splitlines(True) | ||
|
|
||
| changed_file = ("func(p1,(\n" | ||
| " p2,p3,p4,p5))\n").splitlines(True) |
There was a problem hiding this comment.
You do not use the preferred quotation marks.
QuotesBear, severity NORMAL, section python.
The issue can be fixed by applying the following patch:
--- a/tests/general/LineBreakBearTest.py
+++ b/tests/general/LineBreakBearTest.py
@@ -45,7 +45,7 @@
file = "func(p1,(p2,p3,p4,p5))\n".splitlines(True)
changed_file = ("func(p1,(\n"
- " p2,p3,p4,p5))\n").splitlines(True)
+ ' p2,p3,p4,p5))\n').splitlines(True)
results = self.get_results(file)
self.assertEqual(changed_file, results[0].diffs["file"].modified)
tests/general/LineBreakBearTest.py
Outdated
|
|
||
| file = "func(p1,(p2,p3,p4,p5))\n".splitlines(True) | ||
|
|
||
| changed_file = ("func(p1,(\n" |
There was a problem hiding this comment.
You do not use the preferred quotation marks.
QuotesBear, severity NORMAL, section python.
The issue can be fixed by applying the following patch:
--- a/tests/general/LineBreakBearTest.py
+++ b/tests/general/LineBreakBearTest.py
@@ -44,7 +44,7 @@
file = "func(p1,(p2,p3,p4,p5))\n".splitlines(True)
- changed_file = ("func(p1,(\n"
+ changed_file = ('func(p1,(\n'
" p2,p3,p4,p5))\n").splitlines(True)
results = self.get_results(file)
tests/general/LineBreakBearTest.py
Outdated
|
|
||
| self.assertEqual(changed_file, results[0].diffs["file"].modified) | ||
|
|
||
| file = "func(p1,(p2,p3,p4,p5))\n".splitlines(True) |
There was a problem hiding this comment.
You do not use the preferred quotation marks.
QuotesBear, severity NORMAL, section python.
The issue can be fixed by applying the following patch:
--- a/tests/general/LineBreakBearTest.py
+++ b/tests/general/LineBreakBearTest.py
@@ -42,7 +42,7 @@
self.assertEqual(changed_file, results[0].diffs["file"].modified)
- file = "func(p1,(p2,p3,p4,p5))\n".splitlines(True)
+ file = 'func(p1,(p2,p3,p4,p5))\n'.splitlines(True)
changed_file = ("func(p1,(\n"
" p2,p3,p4,p5))\n").splitlines(True)
tests/general/LineBreakBearTest.py
Outdated
|
|
||
| results = self.get_results(file) | ||
|
|
||
| self.assertEqual(changed_file, results[0].diffs["file"].modified) |
There was a problem hiding this comment.
You do not use the preferred quotation marks.
QuotesBear, severity NORMAL, section python.
The issue can be fixed by applying the following patch:
--- a/tests/general/LineBreakBearTest.py
+++ b/tests/general/LineBreakBearTest.py
@@ -40,7 +40,7 @@
results = self.get_results(file)
- self.assertEqual(changed_file, results[0].diffs["file"].modified)
+ self.assertEqual(changed_file, results[0].diffs['file'].modified)
file = "func(p1,(p2,p3,p4,p5))\n".splitlines(True)
tests/general/LineBreakBearTest.py
Outdated
| file = "text(greater than 10 letters)\n".splitlines(True) | ||
|
|
||
| changed_file = ("text(\n" | ||
| " greater than 10 letters)\n").splitlines(True) |
There was a problem hiding this comment.
You do not use the preferred quotation marks.
QuotesBear, severity NORMAL, section python.
The issue can be fixed by applying the following patch:
--- a/tests/general/LineBreakBearTest.py
+++ b/tests/general/LineBreakBearTest.py
@@ -36,7 +36,7 @@
file = "text(greater than 10 letters)\n".splitlines(True)
changed_file = ("text(\n"
- " greater than 10 letters)\n").splitlines(True)
+ ' greater than 10 letters)\n').splitlines(True)
results = self.get_results(file)
tests/general/LineBreakBearTest.py
Outdated
|
|
||
| file = "text(greater than 10 letters)\n".splitlines(True) | ||
|
|
||
| changed_file = ("text(\n" |
There was a problem hiding this comment.
You do not use the preferred quotation marks.
QuotesBear, severity NORMAL, section python.
The issue can be fixed by applying the following patch:
--- a/tests/general/LineBreakBearTest.py
+++ b/tests/general/LineBreakBearTest.py
@@ -35,7 +35,7 @@
file = "text(greater than 10 letters)\n".splitlines(True)
- changed_file = ("text(\n"
+ changed_file = ('text(\n'
" greater than 10 letters)\n").splitlines(True)
results = self.get_results(file)
tests/general/LineBreakBearTest.py
Outdated
|
|
||
| def test_break_on_encapsulators(self): | ||
|
|
||
| file = "text(greater than 10 letters)\n".splitlines(True) |
There was a problem hiding this comment.
You do not use the preferred quotation marks.
QuotesBear, severity NORMAL, section python.
The issue can be fixed by applying the following patch:
--- a/tests/general/LineBreakBearTest.py
+++ b/tests/general/LineBreakBearTest.py
@@ -33,7 +33,7 @@
def test_break_on_encapsulators(self):
- file = "text(greater than 10 letters)\n".splitlines(True)
+ file = 'text(greater than 10 letters)\n'.splitlines(True)
changed_file = ("text(\n"
" greater than 10 letters)\n").splitlines(True)
tests/general/LineBreakBearTest.py
Outdated
| {AnnotationBear.__name__: | ||
| list(annot_results)}, | ||
| 'file': file} | ||
| return list(uut.run_bear_from_section(["file"], arg_dict)) |
There was a problem hiding this comment.
You do not use the preferred quotation marks.
QuotesBear, severity NORMAL, section python.
The issue can be fixed by applying the following patch:
--- a/tests/general/LineBreakBearTest.py
+++ b/tests/general/LineBreakBearTest.py
@@ -29,7 +29,7 @@
{AnnotationBear.__name__:
list(annot_results)},
'file': file}
- return list(uut.run_bear_from_section(["file"], arg_dict))
+ return list(uut.run_bear_from_section(['file'], arg_dict))
def test_break_on_encapsulators(self):
tests/general/LineBreakBearTest.py
Outdated
| def get_results(self, file, section=None): | ||
| if section is None: | ||
| section = self.section | ||
| annot_results = self.annot_uut.execute("file", file) |
There was a problem hiding this comment.
You do not use the preferred quotation marks.
QuotesBear, severity NORMAL, section python.
The issue can be fixed by applying the following patch:
--- a/tests/general/LineBreakBearTest.py
+++ b/tests/general/LineBreakBearTest.py
@@ -23,7 +23,7 @@
def get_results(self, file, section=None):
if section is None:
section = self.section
- annot_results = self.annot_uut.execute("file", file)
+ annot_results = self.annot_uut.execute('file', file)
uut = LineBreakBear(section, Queue())
arg_dict = {'dependency_results':
{AnnotationBear.__name__:
tests/general/LineBreakBearTest.py
Outdated
| self.section.append(Setting('language', 'test')) | ||
| self.section.append(Setting('max_line_length', 10)) | ||
| self.section.append(Setting('coalang_dir', escape(os.path.join( | ||
| os.path.dirname(__file__), "test_files"), '\\'))) |
There was a problem hiding this comment.
You do not use the preferred quotation marks.
QuotesBear, severity NORMAL, section python.
The issue can be fixed by applying the following patch:
--- a/tests/general/LineBreakBearTest.py
+++ b/tests/general/LineBreakBearTest.py
@@ -17,7 +17,7 @@
self.section.append(Setting('language', 'test'))
self.section.append(Setting('max_line_length', 10))
self.section.append(Setting('coalang_dir', escape(os.path.join(
- os.path.dirname(__file__), "test_files"), '\\')))
+ os.path.dirname(__file__), 'test_files'), '\\')))
self.annot_uut = AnnotationBear(self.section, Queue())
def get_results(self, file, section=None):
tests/general/LineBreakBearTest.py
Outdated
| class LineBreakBearTest(unittest.TestCase): | ||
|
|
||
| def setUp(self): | ||
| self.section = Section("") |
There was a problem hiding this comment.
You do not use the preferred quotation marks.
QuotesBear, severity NORMAL, section python.
The issue can be fixed by applying the following patch:
--- a/tests/general/LineBreakBearTest.py
+++ b/tests/general/LineBreakBearTest.py
@@ -13,7 +13,7 @@
class LineBreakBearTest(unittest.TestCase):
def setUp(self):
- self.section = Section("")
+ self.section = Section('')
self.section.append(Setting('language', 'test'))
self.section.append(Setting('max_line_length', 10))
self.section.append(Setting('coalang_dir', escape(os.path.join(
|
Comment on 4219617. Shortlog of the HEAD commit contains 52 character(s). This is 2 character(s) longer than the limit (52 > 50). GitCommitBear, severity NORMAL, section |
Move Generic methods and exceptions from IndentationBear to RangeHelpers and CustomExceptions. Also it modifies the bear to support indent based on keywords.
It adds a basic LineBreakBear and its tests.
|
#1332 should be merged first. |
|
TODO - exceptions and rangehelpers should be moved to other folder. |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
17 similar comments
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
|
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
cobot mark wip <URL>to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!