Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP MP3CheckBear: Add MP3CheckBear #1543

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

shreyans800755
Copy link
Contributor

@shreyans800755 shreyans800755 commented Mar 25, 2017

MP3CheckBear checks mp3 files for consistency and print
several errors and warnings.

Closes: #1519

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!


@staticmethod
def create_arguments(filename, file, config_file):
pass
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

W292 no newline at end of file'

PycodestyleBear (W292), severity NORMAL, section autopep8.

class MP3CheckBear:
"""
Report possible security weaknesses for MP3 files.
For more information, consult <https://code.google.com/archive/p/mp3check/>.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E501 line too long (80 > 79 characters)'

PycodestyleBear (E501), severity NORMAL, section autopep8.

from dependency_management.requirements.DistributionRequirement import (
DistributionRequirement)

@linter(executable='mp3chek',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E302 expected 2 blank lines, found 1'

PycodestyleBear (E302), severity NORMAL, section autopep8.


@staticmethod
def create_arguments(filename, file, config_file):
pass
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/bears/mp3/MP3CheckBear.py
+++ b/bears/mp3/MP3CheckBear.py
@@ -18,4 +18,4 @@
 
     @staticmethod
     def create_arguments(filename, file, config_file):
-        pass+        pass

@@ -0,0 +1,21 @@
from coalib.bearlib.abstractions.Linter import linter
from dependency_management.requirements.DistributionRequirement import (
DistributionRequirement)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/bears/mp3/MP3CheckBear.py
+++ b/bears/mp3/MP3CheckBear.py
@@ -1,6 +1,7 @@
 from coalib.bearlib.abstractions.Linter import linter
 from dependency_management.requirements.DistributionRequirement import (
     DistributionRequirement)
+
 
 @linter(executable='mp3chek',
         output_format='regex',


@staticmethod
def create_arguments(filename, file, config_file):
pass
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line contains following spacing inconsistencies:

  • No newline at EOF.

SpaceConsistencyBear, severity NORMAL, section python.

The issue can be fixed by applying the following patch:

--- a/bears/mp3/MP3CheckBear.py
+++ b/bears/mp3/MP3CheckBear.py
@@ -18,4 +18,4 @@
 
     @staticmethod
     def create_arguments(filename, file, config_file):
-        pass+        pass

from dependency_management.requirements.DistributionRequirement import (
DistributionRequirement)

@linter(executable='mp3chek',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E302 expected 2 blank lines, found 1'

PycodestyleBear (E302), severity NORMAL, section autopep8.

@@ -0,0 +1,22 @@
from coalib.bearlib.abstractions.Linter import linter
from dependency_management.requirements.DistributionRequirement import (
DistributionRequirement)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code does not comply to PEP8.

PEP8Bear, severity NORMAL, section autopep8.

The issue can be fixed by applying the following patch:

--- a/bears/mp3/MP3CheckBear.py
+++ b/bears/mp3/MP3CheckBear.py
@@ -1,6 +1,7 @@
 from coalib.bearlib.abstractions.Linter import linter
 from dependency_management.requirements.DistributionRequirement import (
     DistributionRequirement)
+
 
 @linter(executable='mp3chek',
         output_format='regex',

@shreyans800755
Copy link
Contributor Author

How to install apt-get package (mp3check, to be specific) in ci ?

@shreyans800755 shreyans800755 force-pushed the MP3CheckBear branch 2 times, most recently from 3486e6a to b84a23e Compare March 25, 2017 23:03
@gitmate-bot gitmate-bot added size/S and removed size/M labels Mar 25, 2017
@gitmate-bot gitmate-bot added size/M and removed size/S labels Mar 25, 2017

@staticmethod
def create_arguments(filename, file, config_file):
pass
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mp3check doesn't have any arugments :O ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meetmangukiya Please check the issue from the link.

Copy link
Contributor Author

@shreyans800755 shreyans800755 Mar 26, 2017

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think its better to discuss over here. Just copying comments from the issue:
I've created basic skeleton, and will try to add more options that are available in mp3check. It might take some time as there are lot of options available with mp3check.
Just to clear some doubts:
For testing this bear, which file should I be using ? I mean, to commit the file in tests/mp3/test_files/<file_name>.mp3 as open source, I need a file that is free and open source already, right ?

@@ -0,0 +1,23 @@
from coalib.bearlib.abstractions.Linter import linter
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to add tests as well. Though I'm not sure how you'll test this linter, this is really special. It will take mp3 as input, which is binary and not just any source file that is plain text.

@gitmate-bot
Copy link
Collaborator

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

1 similar comment
@gitmate-bot
Copy link
Collaborator

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

@jayvdb
Copy link
Member

jayvdb commented May 13, 2017

This is blocked by coala/coala#3560 . It cant be merged until binary files are supported.

@jayvdb jayvdb changed the title MP3CheckBear: Add MP3CheckBear WIP MP3CheckBear: Add MP3CheckBear May 13, 2017
@gitmate-bot
Copy link
Collaborator

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

3 similar comments
@gitmate-bot
Copy link
Collaborator

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

@gitmate-bot
Copy link
Collaborator

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

@gitmate-bot
Copy link
Collaborator

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

@jayvdb
Copy link
Member

jayvdb commented Jun 13, 2017

coala/coala#3560 is merged. This bear can now proceed.

MP3CheckBear checks mp3 files for consistency and print
several errors and warnings.

Closes: coala#1519
@gitmate-bot
Copy link
Collaborator

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

4 similar comments
@gitmate-bot
Copy link
Collaborator

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

@gitmate-bot
Copy link
Collaborator

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

@gitmate-bot
Copy link
Collaborator

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

@gitmate-bot
Copy link
Collaborator

Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

MP3Check Bear
5 participants