-
Notifications
You must be signed in to change notification settings - Fork 579
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP MP3CheckBear: Add MP3CheckBear #1543
base: master
Are you sure you want to change the base?
Conversation
bears/mp3/MP3CheckBear.py
Outdated
|
||
@staticmethod | ||
def create_arguments(filename, file, config_file): | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
W292 no newline at end of file'
PycodestyleBear (W292), severity NORMAL, section autopep8
.
bears/mp3/MP3CheckBear.py
Outdated
class MP3CheckBear: | ||
""" | ||
Report possible security weaknesses for MP3 files. | ||
For more information, consult <https://code.google.com/archive/p/mp3check/>. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E501 line too long (80 > 79 characters)'
PycodestyleBear (E501), severity NORMAL, section autopep8
.
bears/mp3/MP3CheckBear.py
Outdated
from dependency_management.requirements.DistributionRequirement import ( | ||
DistributionRequirement) | ||
|
||
@linter(executable='mp3chek', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E302 expected 2 blank lines, found 1'
PycodestyleBear (E302), severity NORMAL, section autopep8
.
bears/mp3/MP3CheckBear.py
Outdated
|
||
@staticmethod | ||
def create_arguments(filename, file, config_file): | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code does not comply to PEP8.
PEP8Bear, severity NORMAL, section autopep8
.
The issue can be fixed by applying the following patch:
--- a/bears/mp3/MP3CheckBear.py
+++ b/bears/mp3/MP3CheckBear.py
@@ -18,4 +18,4 @@
@staticmethod
def create_arguments(filename, file, config_file):
- pass+ pass
bears/mp3/MP3CheckBear.py
Outdated
@@ -0,0 +1,21 @@ | |||
from coalib.bearlib.abstractions.Linter import linter | |||
from dependency_management.requirements.DistributionRequirement import ( | |||
DistributionRequirement) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code does not comply to PEP8.
PEP8Bear, severity NORMAL, section autopep8
.
The issue can be fixed by applying the following patch:
--- a/bears/mp3/MP3CheckBear.py
+++ b/bears/mp3/MP3CheckBear.py
@@ -1,6 +1,7 @@
from coalib.bearlib.abstractions.Linter import linter
from dependency_management.requirements.DistributionRequirement import (
DistributionRequirement)
+
@linter(executable='mp3chek',
output_format='regex',
bears/mp3/MP3CheckBear.py
Outdated
|
||
@staticmethod | ||
def create_arguments(filename, file, config_file): | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line contains following spacing inconsistencies:
- No newline at EOF.
SpaceConsistencyBear, severity NORMAL, section python
.
The issue can be fixed by applying the following patch:
--- a/bears/mp3/MP3CheckBear.py
+++ b/bears/mp3/MP3CheckBear.py
@@ -18,4 +18,4 @@
@staticmethod
def create_arguments(filename, file, config_file):
- pass+ pass
df37660
to
89b802d
Compare
bears/mp3/MP3CheckBear.py
Outdated
from dependency_management.requirements.DistributionRequirement import ( | ||
DistributionRequirement) | ||
|
||
@linter(executable='mp3chek', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E302 expected 2 blank lines, found 1'
PycodestyleBear (E302), severity NORMAL, section autopep8
.
bears/mp3/MP3CheckBear.py
Outdated
@@ -0,0 +1,22 @@ | |||
from coalib.bearlib.abstractions.Linter import linter | |||
from dependency_management.requirements.DistributionRequirement import ( | |||
DistributionRequirement) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code does not comply to PEP8.
PEP8Bear, severity NORMAL, section autopep8
.
The issue can be fixed by applying the following patch:
--- a/bears/mp3/MP3CheckBear.py
+++ b/bears/mp3/MP3CheckBear.py
@@ -1,6 +1,7 @@
from coalib.bearlib.abstractions.Linter import linter
from dependency_management.requirements.DistributionRequirement import (
DistributionRequirement)
+
@linter(executable='mp3chek',
output_format='regex',
e3644d9
to
1f1cada
Compare
How to install apt-get package (mp3check, to be specific) in ci ? |
3486e6a
to
b84a23e
Compare
b84a23e
to
de6fb02
Compare
bears/mp3/MP3CheckBear.py
Outdated
|
||
@staticmethod | ||
def create_arguments(filename, file, config_file): | ||
pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
mp3check doesn't have any arugments :O ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@meetmangukiya Please check the issue from the link.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think its better to discuss over here. Just copying comments from the issue:
I've created basic skeleton, and will try to add more options that are available in mp3check. It might take some time as there are lot of options available with mp3check.
Just to clear some doubts:
For testing this bear, which file should I be using ? I mean, to commit the file in tests/mp3/test_files/<file_name>.mp3 as open source, I need a file that is free and open source already, right ?
@@ -0,0 +1,23 @@ | |||
from coalib.bearlib.abstractions.Linter import linter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You need to add tests as well. Though I'm not sure how you'll test this linter, this is really special. It will take mp3 as input, which is binary and not just any source file that is plain text.
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
1 similar comment
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
de6fb02
to
be48f7e
Compare
114ea2a
to
26df8e4
Compare
26df8e4
to
a80ed8d
Compare
This is blocked by coala/coala#3560 . It cant be merged until binary files are supported. |
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
3 similar comments
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
coala/coala#3560 is merged. This bear can now proceed. |
a80ed8d
to
9e3e05b
Compare
9e3e05b
to
178b631
Compare
MP3CheckBear checks mp3 files for consistency and print several errors and warnings. Closes: coala#1519
178b631
to
a88c815
Compare
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
4 similar comments
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
Hey! This pull request hasn't been updated for a while :/ It would be nice if we could get this going again! |
MP3CheckBear checks mp3 files for consistency and print
several errors and warnings.
Closes: #1519
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
cobot mark wip <URL>
to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!