Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps.sh: Split into smaller files #1769

Merged
merged 2 commits into from
May 26, 2017
Merged

deps.sh: Split into smaller files #1769

merged 2 commits into from
May 26, 2017

Conversation

jayvdb
Copy link
Member

@jayvdb jayvdb commented May 25, 2017

Splitting deps.sh allows the time to complete to be measured by
the CI systems, indicating where build times can be improved.

@jayvdb
Copy link
Member Author

jayvdb commented May 25, 2017

Note this includes a lot of #1386 , and will help with #1759

https://circleci.com/gh/jayvdb/coala-bears/718 is an uncached build. If the now reduced deps.sh is still taking too long , we can split off other chucks of it into separate files, or add time if one of the remaining groups is a single command (e.g. node/ruby) - we can estimate some of these chunks by looking at the Docker builds which do use time.

@jayvdb
Copy link
Member Author

jayvdb commented May 26, 2017

The travis build errors are due to a problem while fetching the bash codecov

https://travis-ci.org/coala/coala-bears/jobs/236197564#L3841

coala/coala#3718 is the solution for that problem.

@jayvdb jayvdb force-pushed the split-deps.sh branch 4 times, most recently from a7fef3f to b2d8fa9 Compare May 26, 2017 06:16
jayvdb added 2 commits May 26, 2017 13:18
Unused and noisy.

Closes coala#1774
Related to coala#1123
Splitting deps.sh allows the time to complete to be measured by
the CI systems, indicating where build times can be improved.

Related to coala#1759
Related to coala#1773
@jayvdb
Copy link
Member Author

jayvdb commented May 26, 2017

Splitting it makes it easier to see problems like #1777 , as deps.sh should now be very quick when cached.

@jayvdb jayvdb requested review from yash-nisar, underyx and Mixih May 26, 2017 07:11
@jayvdb jayvdb requested a review from yukiisbored May 26, 2017 09:50
@yukiisbored
Copy link
Member

ack b2d8fa9

@yukiisbored
Copy link
Member

ack b738960

@jayvdb
Copy link
Member Author

jayvdb commented May 26, 2017

@rultor merge

@rultor
Copy link

rultor commented May 26, 2017

@rultor merge

@jayvdb OK, I'll try to merge now. You can check the progress of the merge here

@rultor rultor merged commit b2d8fa9 into coala:master May 26, 2017
@rultor
Copy link

rultor commented May 26, 2017

@rultor merge

@jayvdb Done! FYI, the full log is here (took me 2min)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

4 participants