PrettierLintBear.py: Fix syntax error regex #2414
Conversation
bears/js/PrettierLintBear.py
Outdated
| @@ -23,13 +23,17 @@ class PrettierLintBear: | |||
| 'Multi-line objects'} | |||
| SEE_MORE = 'https://prettier.io/' | |||
|
|
|||
| regex = re.compile(r'L(?P<line>\d+)C(?P<column>\d+): (?P<message>.*)') | |||
There was a problem hiding this comment.
im wondering how this could have been so wrong?
see issue
| yield from self.process_output_corrected(stdout, filename, file) | ||
| yield from self.process_output_regex(stderr, filename, file, | ||
| self.regex) | ||
| if stdout == '\n': |
There was a problem hiding this comment.
When there is a syntax error stdout has a \n. So we should only show the syntax error result.
There was a problem hiding this comment.
But the regex being applied to stdout will ignore the \n..?
There was a problem hiding this comment.
no we are using process_output_corrected since the bear prints corrected output to stdout
There was a problem hiding this comment.
That feels like a bug in process_output_corrected. If there was an error, the linter can only emit \n on stdout. It shouldnt decide that means the file should be blanked.
|
@gitmate-bot ff |
|
Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently |
|
Automated fastforward failed! Please fastforward your pull request manually via the command line. Reason: |
|
@gitmate-bot rebase |
|
Hey! I'm GitMate.io! This pull request is being rebased automatically. Please DO NOT push while rebase is in progress or your changes would be lost permanently |
|
Automated rebase with GitMate.io was successful! 🎉 |
|
@gitmate-bot ff |
|
Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently |
|
Automated fastforward with GitMate.io was successful! 🎉 |
Fixes #2365
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
corobo mark wip <URL>to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!