Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.ci/appveyor.yml: Add Python 3.6 jobs #2509

Closed
wants to merge 6 commits into from

Conversation

jayvdb
Copy link
Member

@jayvdb jayvdb commented May 26, 2018

For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!

Checklist

  • I read the commit guidelines and I've followed
    them.
  • I ran coala over my code locally. (All commits have to pass
    individually.
    It is not sufficient to have "fixup commits" on your PR,
    our bot will still report the issues for the previous commit.) You will
    likely receive a lot of bot comments and build failures if coala does not
    pass on every single commit!

After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.

Please consider helping us by reviewing other peoples pull requests as well:

The more you review, the more your score will grow at coala.io and we will
review your PRs faster!

.ci/appveyor.yml Outdated
@@ -6,6 +6,14 @@ environment:
CMD_IN_ENV: "cmd /E:ON /V:ON /C .\\.ci\\run_with_env.cmd"

matrix:
- PYTHON: "C:\\Python36"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

syntax error: expected , but found ''

Origin: YAMLLintBear, Section: all.yml.

@jayvdb
Copy link
Member Author

jayvdb commented Jun 17, 2018

Blocked by #2511

- PYTHON: "C:\\Python36"
PYTHON_VERSION: "3.6"
PYTHON_ARCH: "32"

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (99 > 79 characters) (line-length)

Origin: YAMLLintBear, Section: all.yml.

.ci/appveyor.yml Outdated
@@ -49,7 +49,8 @@ install:
- "python --version"
- "python -c \"import struct; print(struct.calcsize('P') * 8)\""
- "%CMD_IN_ENV% python -m pip install --upgrade setuptools==21"
- "%CMD_IN_ENV% python -m pip install -r requirements.txt \
- "%CMD_IN_ENV% python -m pip install --install-option=--no-cython-compile \
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a potentially useful part of this PR, but the objective of this PR has been done in #2910 , which uses a slightly different approach of first installing lxml and tries very hard to avoid letting pip select source tarballs - requiring wheels.

@jayvdb jayvdb closed this Jul 21, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

2 participants