GixyBear.py: add GixyBear #2745
Conversation
bears/general/GixyBear.py
Outdated
| class GixyBear: | ||
| @staticmethod | ||
| def create_arguments(filename, file, config_file): | ||
| return '--', filename |
There was a problem hiding this comment.
Line contains following spacing inconsistencies:
- No newline at EOF.
Origin: SpaceConsistencyBear, Section: all.python.
The issue can be fixed by applying the following patch:
--- a/tmp/tmpt_yx8rpp/bears/general/GixyBear.py
+++ b/tmp/tmpt_yx8rpp/bears/general/GixyBear.py
@@ -6,4 +6,4 @@
class GixyBear:
@staticmethod
def create_arguments(filename, file, config_file):
- return '--', filename+ return '--', filename
tests/general/GixyBearTest.py
Outdated
| file, | ||
| [Result.from_values('GixyBear', | ||
| 'done', | ||
| file)]) |
There was a problem hiding this comment.
Line contains following spacing inconsistencies:
- No newline at EOF.
Origin: SpaceConsistencyBear, Section: all.python.
The issue can be fixed by applying the following patch:
--- a/tmp/tmpt_yx8rpp/tests/general/GixyBearTest.py
+++ b/tmp/tmpt_yx8rpp/tests/general/GixyBearTest.py
@@ -18,4 +18,4 @@
file,
[Result.from_values('GixyBear',
'done',
- file)])+ file)])
| @@ -0,0 +1,9 @@ | |||
| from coalib.bearlib.abstractions.Linter import linter | |||
There was a problem hiding this comment.
The code does not comply to PEP8.
Origin: PEP8Bear, Section: all.autopep8.
The issue can be fixed by applying the following patch:
--- a/tmp/tmpt_yx8rpp/bears/general/GixyBear.py
+++ b/tmp/tmpt_yx8rpp/bears/general/GixyBear.py
@@ -1,4 +1,5 @@
from coalib.bearlib.abstractions.Linter import linter
+
@linter(executable='gixy',
output_format='corrected',
bears/general/GixyBear.py
Outdated
| class GixyBear: | ||
| @staticmethod | ||
| def create_arguments(filename, file, config_file): | ||
| return '--', filename |
There was a problem hiding this comment.
The code does not comply to PEP8.
Origin: PEP8Bear, Section: all.autopep8.
The issue can be fixed by applying the following patch:
--- a/tmp/tmpt_yx8rpp/bears/general/GixyBear.py
+++ b/tmp/tmpt_yx8rpp/bears/general/GixyBear.py
@@ -6,4 +6,4 @@
class GixyBear:
@staticmethod
def create_arguments(filename, file, config_file):
- return '--', filename+ return '--', filename
| @@ -0,0 +1,9 @@ | |||
| from coalib.bearlib.abstractions.Linter import linter | |||
|
|
|||
| @linter(executable='gixy', | |||
There was a problem hiding this comment.
E302 expected 2 blank lines, found 1
Origin: PycodestyleBear (E302), Section: all.autopep8.
bears/general/GixyBear.py
Outdated
| class GixyBear: | ||
| @staticmethod | ||
| def create_arguments(filename, file, config_file): | ||
| return '--', filename |
There was a problem hiding this comment.
W292 no newline at end of file
Origin: PycodestyleBear (W292), Section: all.autopep8.
tests/general/GixyBearTest.py
Outdated
| file, | ||
| [Result.from_values('GixyBear', | ||
| 'done', | ||
| file)]) |
There was a problem hiding this comment.
The code does not comply to PEP8.
Origin: PEP8Bear, Section: all.autopep8.
The issue can be fixed by applying the following patch:
--- a/tmp/tmpt_yx8rpp/tests/general/GixyBearTest.py
+++ b/tmp/tmpt_yx8rpp/tests/general/GixyBearTest.py
@@ -18,4 +18,4 @@
file,
[Result.from_values('GixyBear',
'done',
- file)])+ file)])
tests/general/GixyBearTest.py
Outdated
| file, | ||
| [Result.from_values('GixyBear', | ||
| 'done', | ||
| file)]) |
There was a problem hiding this comment.
W292 no newline at end of file
Origin: PycodestyleBear (W292), Section: all.autopep8.
|
Comment on 60d28d8. Shortlog of HEAD commit does not match given regex: ([^:]|[^:]+: [A-Z0-9].*) Origin: GitCommitBear, Section: |
|
Comment on a3819d8. Shortlog of HEAD commit does not match given regex: ([^:]|[^:]+: [A-Z0-9].*) Origin: GitCommitBear, Section: |
.travis.yml
Outdated
| @@ -110,6 +110,7 @@ addons: | |||
| - flawfinder | |||
| - gfortran | |||
| - ghc | |||
| - gixy | |||
There was a problem hiding this comment.
I doubt that gixy is a apt-get package.
how do you install it on your computer?
find other bears that you would install the same way, and look at how they are installed onto the CI
bears/general/GixyBear.py
Outdated
|
|
||
|
|
||
| @linter(executable='gixy', | ||
| output_format='corrected', |
There was a problem hiding this comment.
please read the linter guide. this linter probably needs to be in regex message mode.
This adds gixy bear to coala-bears Closes #1724
|
|
||
|
|
||
| @linter(executable='gixy', | ||
| output_format='regex', |
There was a problem hiding this comment.
this only says which mode the bear is in. you need to write the regex. see the linter bear docs. it has a tutorial which covers this.
This adds gixy bear to coala-bears
Closes #1724
For short term contributors: we understand that getting your commits well
defined like we require is a hard task and takes some learning. If you
look to help without wanting to contribute long term there's no need
for you to learn this. Just drop us a message and we'll take care of brushing
up your stuff for merge!
Checklist
them.
individually. It is not sufficient to have "fixup commits" on your PR,
our bot will still report the issues for the previous commit.) You will
likely receive a lot of bot comments and build failures if coala does not
pass on every single commit!
After you submit your pull request, DO NOT click the 'Update Branch' button.
When asked for a rebase, consult coala.io/rebase
instead.
Please consider helping us by reviewing other peoples pull requests as well:
corobo mark wip <URL>to get it outof the review queue.
The more you review, the more your score will grow at coala.io and we will
review your PRs faster!