-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build setup.py and requirements files using moban #226
Conversation
setup.py
Outdated
"Adhityaa Chandrasekar", | ||
author='The coala developers', | ||
author_email='[email protected]', | ||
maintainer='Satwik Kansal, Adrian Zatreanu, Alexandros Dimos, Adhityaa Chandrasekar', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
E501 line too long (95 > 80 characters)
Origin: PycodestyleBear (E501), Section: autopep8
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://gitlab.com/coala/mobans/issues/16 to fix this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
submitted a PR https://gitlab.com/coala/mobans/merge_requests/15, have a look at it
setup.py
Outdated
"Adhityaa Chandrasekar", | ||
author='The coala developers', | ||
author_email='[email protected]', | ||
maintainer='Satwik Kansal, Adrian Zatreanu, Alexandros Dimos, Adhityaa Chandrasekar', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Line is longer than allowed. (95 > 80)
Origin: LineLengthBear, Section: linelength
.
Travis tests have failedHey @jayvdb, 3rd Buildcoala --non-interactive
|
coala-mobans provides a set of metadata common to all repositories, with local overrides. Related to coala/meta#117
@@ -1,6 +1,30 @@ | |||
overrides: coala.yaml | |||
|
|||
name: coala-quickstart | |||
contact: [email protected] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I thought we had @coala.io
domain e-mails
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR is not to change the contents of setup.py . These values are just copies of what is in there.
url: https://github.com/coala/coala-quickstart | ||
docs_dir: false | ||
|
||
maintainers: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why is this False
😅
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
template logic requires it in order to use maintainer_list
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah I see.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only a couple of questions, otherwise LGTM ;)
ack d5e0c3f |
@gitmate-bot ff |
Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently |
Automated fastforward with GitMate.io was successful! 🎉 |
coala-mobans provides a set of metadata common to
all repositories, with local overrides.
Related to coala/meta#117