Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build setup.py and requirements files using moban #226

Merged
merged 1 commit into from
Jul 11, 2018
Merged

Conversation

jayvdb
Copy link
Member

@jayvdb jayvdb commented May 12, 2018

coala-mobans provides a set of metadata common to
all repositories, with local overrides.

Related to coala/meta#117

setup.py Outdated
"Adhityaa Chandrasekar",
author='The coala developers',
author_email='[email protected]',
maintainer='Satwik Kansal, Adrian Zatreanu, Alexandros Dimos, Adhityaa Chandrasekar',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

E501 line too long (95 > 80 characters)

Origin: PycodestyleBear (E501), Section: autopep8.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

submitted a PR https://gitlab.com/coala/mobans/merge_requests/15, have a look at it

setup.py Outdated
"Adhityaa Chandrasekar",
author='The coala developers',
author_email='[email protected]',
maintainer='Satwik Kansal, Adrian Zatreanu, Alexandros Dimos, Adhityaa Chandrasekar',

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Line is longer than allowed. (95 > 80)

Origin: LineLengthBear, Section: linelength.

@TravisBuddy
Copy link

Travis tests have failed

Hey @jayvdb,
Please read the following log in order to understand the failure reason.
It'll be awesome if you fix what's wrong and commit the changes.

3rd Build

coala --non-interactive
Executing section all...
Executing section all.python...
**** PyUnusedCodeBear [Section <empty> | Severity NORMAL] ****
!    ! This file contains unused source code.
[----] /home/travis/build/coala/coala-quickstart/setup.py
[++++] /home/travis/build/coala/coala-quickstart/setup.py
[   8] import setuptools.command.build_py
[INFO][16:21:10] Applied 'ShowPatchAction' on 'setup.py' from 'PyUnusedCodeBear'.
Executing section all.quotes...
[WARNING][16:21:10] No files matching '/home/travis/build/coala/coala-quickstart/tests/**.py' were found. If this rule is not required, you can remove it from section [all.quotes] in your .coafile to deactivate this warning.
Executing section all.autopep8...
Executing section all.linelength...
Executing section all.commit...
Executing section all.yml...
[WARNING][16:21:21] No files matching '/home/travis/build/coala/coala-quickstart/tests/**/*.yml' were found. If this rule is not required, you can remove it from section [all.yml] in your .coafile to deactivate this warning.
Executing section cli...

coala-mobans provides a set of metadata common to
all repositories, with local overrides.

Related to coala/meta#117
@@ -1,6 +1,30 @@
overrides: coala.yaml

name: coala-quickstart
contact: [email protected]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we had @coala.io domain e-mails

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is not to change the contents of setup.py . These values are just copies of what is in there.

url: https://github.com/coala/coala-quickstart
docs_dir: false

maintainers: false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why is this False 😅

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

template logic requires it in order to use maintainer_list

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see.

Copy link
Member

@satwikkansal satwikkansal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only a couple of questions, otherwise LGTM ;)

@satwikkansal
Copy link
Member

ack d5e0c3f

@jayvdb
Copy link
Member Author

jayvdb commented Jul 11, 2018

@gitmate-bot ff

@gitmate-bot
Copy link

Hey! I'm GitMate.io! This pull request is being fastforwarded automatically. Please DO NOT push while fastforward is in progress or your changes would be lost permanently ⚠️

@gitmate-bot gitmate-bot merged commit d5e0c3f into master Jul 11, 2018
@gitmate-bot
Copy link

Automated fastforward with GitMate.io was successful! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

5 participants