Optimize and restructure the backend #118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
webr-init.html -> CSS styles to qwebr-styling.css JS initialization to qwebr-init.js
The Monaco Editor routine is now encapsulated into a single function that is used by each interactive chunk. This cuts down on the number of times the same code appears multiple times in the document.
The original HTML has been shifted completely to the qwebr-cell-elements.js.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR, we work towards achieving the second goal of #93
Specifically, we sunset the
webr-init.htmlfile in favor of two separate template files:qwebr-styling.css: The extension style data (minus the external dependencies on monaco and fontawesome)qwebr-init.js: The initialization routine for splicing in the webR status indicator and bringing webR online.We are also no longer replicating out the function definition of
executeCode()each time we have an interactive or output cell on the page. Instead, we now have multiple subfunctions defined once inside of theqwebr-compute-engine.js.Similar improvements have been made regarding initializing the monaco editor. The initialization routine for each Monaco Editor is now contained within
qwebr-monaco-editor-element.js.HTML elements for the interactive and non-interactive areas have been shifted fully over to JS code. This allows us to move the cell selection out of the Lua filter and into JS.
TODO