Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow multiple date formats in frontmatter published date #1134

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tglman
Copy link
Contributor

@tglman tglman commented May 13, 2023

Hi,

As the description say, this allow to have multiple date formats for the published_date in the front matter, and still use the the liquid date time parsing, I started this implementation because of a regression on the liquid serde implementation of DateTime, if you cargo update the dependencies existing sites may fail to parse because the serde deserialization of DateTime require now the milliseconds, I'm going to open an issue on liquid for this(if not already there).

@epage
Copy link
Member

epage commented May 18, 2023

Is there a reason we shouldn't fix this in liquid instead?

@tglman
Copy link
Contributor Author

tglman commented May 27, 2023

Hi,

I just opened a PR to fix this in liquid: cobalt-org/liquid-rust#500, that will fix the regression anyway this PR also include the support of multiple date formats, like date formats without time, which I think it does make sense in term of blog posts.

Bye

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants