Fix feedback form #490
Merged
Fix feedback form #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cobalt-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
mahmoudadly-cobalt
force-pushed
the
fix/FX-4175/fix-feedback-form-2
branch
from
f966e0b to
db7d00a
Compare
TaylorBriggs
approved these changes
May 29, 2024
| }; | ||
|
|
||
| dataLayer.push(args); |
There was a problem hiding this comment.
Where does dataLayer come from? What is it?
There was a problem hiding this comment.
It is from Google Tag Manager: https://developers.google.com/tag-platform/tag-manager/datalayer
Co-authored-by: Wolfgang Becker <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket: https://zombie.atlassian.net/browse/FX-4175
Changelog
Updated
Fixed the overwrite partial created initially in #101 by
Note: I could only validate that the event is pushed to the dataLayer. But I can't validate the data in Google Tag Manager before merging.
(the feedback form style hasn't changed 👇 )
(a thank you not appears for a short time 👇 )
(the buttons stay disabled afterwards 👇 )
(the event appears in the dataLayer object 👇 )
Preview This Change
To see how this change looks in production, scroll down to Deploy Preview. Select the link that looks like
https://deploy-preview-<num>--cobalt-docs.netlify.app/Variables
Help us support a “Write once, publish everywhere” single source of truth. If you see a line that looks like:
{{% asset-categories %}}You’ve found a shortcode that we include in multiple documents.
You’ll find the content of the shortcode in the following directory:
https://github.com/cobalthq/cobalt-product-public-docs/tree/main/layouts/shortcodes
That shortcode has the same base name as what you see in the PR, such as
asset-categories.html.Checklist for PR Author
[ ] Did you check for broken links and alt text?
Be sure to check for broken links and Alt Text issues. We have a partially automated process,
as described in this section of our repository README:
Test Links and Alt Attributes.