Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create secure-code-review.md #513

Merged
merged 4 commits into from
Jul 22, 2024
Merged

Conversation

molfinn
Copy link
Contributor

@molfinn molfinn commented Jul 17, 2024

Changelog

Added

Page Deploy Preview Comment
Name Link Comment

Updated

Page Deploy Preview Comment
Name Link Comment

Preview This Change

To see how this change looks in production, scroll down to Deploy Preview. Select the link that looks like https://deploy-preview-<num>--cobalt-docs.netlify.app/

Variables

Help us support a “Write once, publish everywhere” single source of truth. If you see a line that looks like:

{{% asset-categories %}}

You’ve found a shortcode that we include in multiple documents.

You’ll find the content of the shortcode in the following directory:

https://github.com/cobalthq/cobalt-product-public-docs/tree/main/layouts/shortcodes

That shortcode has the same base name as what you see in the PR, such as asset-categories.html.

Checklist for PR Author

[ ] Did you check for broken links and alt text?

Be sure to check for broken links and Alt Text issues. We have a partially automated process,
as described in this section of our repository README:
Test Links and Alt Attributes.

@molfinn molfinn added the draft Not ready for review label Jul 17, 2024
Copy link

netlify bot commented Jul 17, 2024

Deploy Preview for cobalt-docs ready!

Name Link
🔨 Latest commit 8212e96
🔍 Latest deploy log https://app.netlify.com/sites/cobalt-docs/deploys/669821e0391a170008b82f02
😎 Deploy Preview https://deploy-preview-513--cobalt-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

molfinn added 2 commits July 17, 2024 14:13
include SCR as clickable page
Adding SCR content
@molfinn molfinn requested a review from reginandrade July 17, 2024 19:53
@molfinn molfinn removed the draft Not ready for review label Jul 19, 2024
@molfinn
Copy link
Contributor Author

molfinn commented Jul 19, 2024

@reginandrade can you take a look at this please :)

@molfinn molfinn merged commit efffd0b into main Jul 22, 2024
10 checks passed
@molfinn molfinn deleted the NO-TICKET-creating-a-new-scr-page branch July 22, 2024 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants