stop removal of spaces that causes display changes #150
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewsmedina
requested changes
Jan 18, 2021
Comment on lines
+189
to
+191
| if is_text_tag(soup.parent): | ||
| # NavigableString is within a text tag element | ||
| return (True, True) |
There was a problem hiding this comment.
This function always returns the same value. Why this is necessary?
There was a problem hiding this comment.
Essentially, this is an optimization. Prior to this, I had something like this:
prev_flow = (
is_text_tag(soup.previous_sibling)
or is_text_tag(soup.parent)
)
next_flow = (
is_text_tag(soup.next_sibling)
or is_text_tag(soup.parent)
)Then I noticed that I was essentially running is_text_tag(soup.parent) twice and that when True it forces both prev_flow and next_flow to True.
I'm open to suggestions on a code comment to make it more understandable.
tisdall
force-pushed
the
keep_needed_inline_text_spaces
branch
from
988be35 to
25b0332
Compare
|
I must have accidentally hit space while having the test_minify.py open or something as I had run the tests locally. I've updated that one test and made the suggested change and updated the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I can't believe how much time I spent on this... 😄
This PR fixes some additional cases of removal of spaces that changes the display. Most of the cases are poorly formed HTML, but unfortunately we're not always in control over that. In some edge cases it's leaving a single space that doesn't affect display in the browsers I tested, but I think this keeps things simple and errs on the side of leaving a space that may affect display. I looked further into #121 and #21 and neither of them are actually bugs in the latest version.
Examples
(I'm going to exclude the
<html>wrappers in the output for simplicity)Example 1:
Stop removal of needed space for proper display.
Un-minified:
<p> <i>first </i>second </p>which displays as: first seconddjango-htmlmi 0.11.0:
<p><i>first</i>second</p>which displays as: firstsecondthis PR:
<p><i>first </i>second</p>which displays as: first secondExample 2:
Stop the removal of a space that has styling applied to it (hard to duplicate in github, but you can see the space is underlined between the words)
Un-minified:
<p><u>first </u> <s> second</s></p>which displays as: firstseconddjango-htmlmi 0.11.0:
<p><u>first</u> <s>second</s></p>which displays as: firstsecondthis PR:
<p><u>first </u> <s> second</s></p>which displays as: firstsecondThis one is weird as the order dictates what styling that space in the middle receives. If you switch the order then the space in the middle gets a strike-through styling, but I have no idea if that's consistent across all browser renderers.