Avoid KeyError if no Content-Type header; don't perform unnecessary checks in can_minify_response #87
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
django-htmlmin
in my project, I found that some responses were being returned without theContent-Type
header. Even though I was excluding those URLs from being minified using the settings.pyEXCLUDE_FROM_MINIFYING
option, the structure of the middleware'scan_minify_response
function did two things that resulted in errors:Content-Type
header in therequest
dictionary would throw aKeyError
if the header wasn't present.I've fixed both of those issues, as well as adding an additional test in case
request._hit_htmlmin
is ever set toFalse
(which it shouldn't be, so why not have a test for it?)