Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Start using a generic retry function #1251

Merged
merged 1 commit into from
Feb 26, 2024
Merged

Start using a generic retry function #1251

merged 1 commit into from
Feb 26, 2024

Conversation

jsfehler
Copy link
Collaborator

  • Rewrite _find to only handle the Selenium actions.
  • Rewrite find_by to use the generic _retry function.
  • Rewrite the _retry function to return the result of the function instead of a bool.

@jsfehler jsfehler requested a review from fsouza February 23, 2024 19:00
fsouza
fsouza approved these changes Feb 26, 2024
View reviewed changes
Copy link
Contributor

@fsouza fsouza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@jsfehler jsfehler merged commit 5889c16 into cobrateam:master Feb 26, 2024
26 checks passed
@jsfehler jsfehler deleted the std_retry branch February 27, 2024 04:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsouza fsouza fsouza approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsfehler @fsouza