Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use pytest fixtures to setup browser, split up chrome and firefox jobs #1299

Merged
merged 1 commit into from
Jun 14, 2024
Merged

Use pytest fixtures to setup browser, split up chrome and firefox jobs #1299

merged 1 commit into from
Jun 14, 2024

Conversation

jsfehler
Copy link
Collaborator

This PR adds:

  • A command line option for setting the browser name when running our test suite.
  • A pytest fixture for the browser and browser configuration which consumes the command line option

Doing so allows us to resolve the browser's name on a per-job basis instead of on each individual test.

@jsfehler jsfehler force-pushed the refactor_test_fixtures branch from ffb2c86 to 904267c Compare June 14, 2024 13:14
@jsfehler jsfehler force-pushed the refactor_test_fixtures branch from ed30ae7 to 2db66d5 Compare June 14, 2024 14:31
@jsfehler jsfehler merged commit 17ef237 into cobrateam:master Jun 14, 2024
26 checks passed
@jsfehler jsfehler deleted the refactor_test_fixtures branch June 14, 2024 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jsfehler