generated from cockpit-project/starter-kit
-
Notifications
You must be signed in to change notification settings - Fork 37
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Support copy&pasting files with administrator privileges
Allows administrator to paste files into directories owned by a different user.
- Loading branch information
1 parent
564357a
commit dc5296d
Showing
10 changed files
with
490 additions
and
31 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,221 @@ | ||
| /* | ||
| * This file is part of Cockpit. | ||
| * | ||
| * Copyright (C) 2024 Red Hat, Inc. | ||
| * | ||
| * This program is free software: you can redistribute it and/or modify | ||
| * it under the terms of the GNU General Public License as published by | ||
| * the Free Software Foundation, either version 3 of the License, or | ||
| * (at your option) any later version. | ||
| * | ||
| * This program is distributed in the hope that it will be useful, | ||
| * but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
| * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
| * GNU General Public License for more details. | ||
| * | ||
| * You should have received a copy of the GNU General Public License | ||
| * along with this program. If not, see <https://www.gnu.org/licenses/>. | ||
| */ | ||
|
|
||
| import React, { useState } from 'react'; | ||
|
|
||
| import { AlertVariant } from "@patternfly/react-core/dist/esm/components/Alert"; | ||
| import { Button } from "@patternfly/react-core/dist/esm/components/Button"; | ||
| import { Form, FormGroup } from "@patternfly/react-core/dist/esm/components/Form"; | ||
| import { FormSelect, FormSelectOption } from "@patternfly/react-core/dist/esm/components/FormSelect"; | ||
| import { Modal, ModalVariant } from "@patternfly/react-core/dist/esm/components/Modal"; | ||
| import { Text, TextContent } from "@patternfly/react-core/dist/esm/components/Text"; | ||
|
|
||
| import cockpit from 'cockpit'; | ||
| import { FileInfo } from 'cockpit/fsinfo.ts'; | ||
| import type { Dialogs, DialogResult } from 'dialogs'; | ||
| import { useEvent, useInit } from 'hooks.ts'; | ||
| import { superuser } from 'superuser'; | ||
|
|
||
| import { useFilesContext } from '../common.ts'; | ||
| import type { ClipboardInfo, FolderFileInfo } from '../common.ts'; | ||
| import { get_owner_candidates } from '../ownership.tsx'; | ||
|
|
||
| const _ = cockpit.gettext; | ||
|
|
||
| async function pasteAsOwner(clipboard: ClipboardInfo, | ||
| dstPath: string, | ||
| ownerStr: string, | ||
| addAlert: (title: string, variant: AlertVariant, key: string, detail?: string) => void) { | ||
| try { | ||
| await cockpit.spawn([ | ||
| "cp", | ||
| "-a", | ||
| "--recursive", | ||
| ...clipboard.files.map(file => clipboard.path + "/" + file.name), | ||
| dstPath | ||
| ], { superuser: "require" }); | ||
|
|
||
| // "original" is a special value, valid values are formatted as 'user:group' | ||
| if (ownerStr !== "original") { | ||
| await cockpit.spawn([ | ||
| "chown", | ||
| "--recursive", | ||
| ownerStr, | ||
| ...clipboard.files.map(file => dstPath + "/" + file.name), | ||
| ], { superuser: "require" }); | ||
| } | ||
| } catch (err) { | ||
| const e = err as cockpit.BasicError; | ||
| addAlert(_("Pasting failed"), AlertVariant.danger, `${new Date().getTime()}`, e.message); | ||
|
|
||
| // cleanup potentially copied files in case of "chown" fail | ||
| try { | ||
| await cockpit.spawn([ | ||
| "rm", | ||
| "-rf", | ||
| ...clipboard.files.map(file => dstPath + "/" + file.name) | ||
| ], { superuser: "try" }); | ||
| } catch (ex) { | ||
| console.warn(`Failed to clean up copied files in ${dstPath}`, ex); | ||
| } | ||
| } | ||
| } | ||
|
|
||
| function ownershipTypes(files: FolderFileInfo[]) { | ||
| const owners = new Set(); | ||
|
|
||
| for (const file of files) { | ||
| const user = file.user; | ||
| const group = file.group; | ||
|
|
||
| if (user === group) { | ||
| owners.add(String(user)); | ||
| } else { | ||
| owners.add(`${user}:${group}`); | ||
| } | ||
| } | ||
|
|
||
| return [...owners]; | ||
| } | ||
|
|
||
| function makeCandidatesMap(currentUser: cockpit.UserInfo, cwdInfo: FileInfo, clipboard: ClipboardInfo) { | ||
| // keys in Map() are ordered in the same order as they were inserted | ||
| // and has no duplicates. Only the first insertion. | ||
| const map: Map<string, string> = new Map(); | ||
| const candidates = get_owner_candidates(currentUser, cwdInfo); | ||
|
|
||
| // also add current ownership if it is same for all files (shallow check) | ||
| const firstFile = clipboard.files[0]; | ||
| const firstOwnerStr = `${firstFile.user}:${firstFile.group}`; | ||
| const uniqueOwners = ownershipTypes(clipboard.files); | ||
| if (uniqueOwners.length === 1) { | ||
| candidates.add(firstOwnerStr); | ||
| } | ||
|
|
||
| candidates.forEach(owner => { | ||
| const split = owner.split(':'); | ||
| let key = owner; | ||
| if (split.length === 2 && split[0] === split[1]) { | ||
| key = split[0]; | ||
| } | ||
| if (uniqueOwners.length === 1 && owner === firstOwnerStr) { | ||
| key = `${key} ${_("(original owner)")}`; | ||
| } | ||
|
|
||
| map.set(key, owner); | ||
| }); | ||
|
|
||
| // add option to keep the same permissions on mixed permissions files | ||
| if (uniqueOwners.length > 1) { | ||
| const dots = uniqueOwners.length > 2 ? ", ..." : ""; | ||
| map.set(`${_("keep original owners")} (${uniqueOwners.slice(0, 2).join(", ")}${dots})`, "original"); | ||
| } | ||
|
|
||
| return map; | ||
| } | ||
|
|
||
| const CopyPasteAsOwnerModal = ({ | ||
| clipboard, | ||
| dialogResult, | ||
| path, | ||
| } : { | ||
| clipboard: ClipboardInfo, | ||
| dialogResult: DialogResult<void>, | ||
| path: string, | ||
| }) => { | ||
| // @ts-expect-error superuser.js is not typed | ||
| useEvent(superuser, "changed"); | ||
| const [selectedOwner, setSelectedOwner] = useState<string | undefined>(); | ||
| const { cwdInfo, addAlert } = useFilesContext(); | ||
| const [candidatesMap, setCandidatesMap] = useState<Map<string, string> | undefined>(); | ||
|
|
||
| useInit(async () => { | ||
| const userInfo = await cockpit.user(); | ||
| let map: Map<string, string> = new Map(); | ||
|
|
||
| if (superuser.allowed && userInfo && cwdInfo) { | ||
| map = makeCandidatesMap(userInfo, cwdInfo, clipboard); | ||
| if (selectedOwner === undefined) { | ||
| setSelectedOwner(map.keys().next().value); | ||
| } | ||
| } | ||
|
|
||
| setCandidatesMap(map); | ||
| }); | ||
|
|
||
| if (selectedOwner === undefined || candidatesMap === undefined) { | ||
| return; | ||
| } | ||
|
|
||
| const selectedVal = candidatesMap.get(selectedOwner); | ||
| cockpit.assert(selectedVal !== undefined, "New file ownership undefined"); | ||
|
|
||
| const modalFooter = ( | ||
| <> | ||
| <Button | ||
| variant="primary" | ||
| onClick={() => { | ||
| pasteAsOwner(clipboard, path, selectedVal, addAlert); | ||
| dialogResult.resolve(); | ||
| }} | ||
| > | ||
| {_("Paste")} | ||
| </Button> | ||
| <Button variant="link" onClick={() => dialogResult.resolve()}>{_("Cancel")}</Button> | ||
| </> | ||
| ); | ||
|
|
||
| return ( | ||
| <Modal | ||
| id="paste-owner-modal" | ||
| position="top" | ||
| title={_("Paste as owner")} | ||
| isOpen | ||
| onClose={() => dialogResult.resolve()} | ||
| variant={ModalVariant.small} | ||
| footer={modalFooter} | ||
| > | ||
| <Form isHorizontal> | ||
| <TextContent> | ||
| <Text> | ||
| {/*eslint-disable-line*/ _("Files being pasted have a different owner. By default, ownership will be changed to match the destination directory.")} | ||
| </Text> | ||
| </TextContent> | ||
| <FormGroup fieldId="paste-as-owner" label={_("New owner")}> | ||
| <FormSelect | ||
| id='paste-owner-select' | ||
| value={selectedOwner} | ||
| onChange={(_ev, val) => setSelectedOwner(val)} | ||
| > | ||
| {[...candidatesMap.keys()].map(user => | ||
| <FormSelectOption | ||
| key={user} | ||
| value={user} | ||
| label={user} | ||
| />)} | ||
| </FormSelect> | ||
| </FormGroup> | ||
| </Form> | ||
| </Modal> | ||
| ); | ||
| }; | ||
|
|
||
| export function show_copy_paste_as_owner(dialogs: Dialogs, clipboard: ClipboardInfo, path: string) { | ||
| dialogs.run(CopyPasteAsOwnerModal, { clipboard, path }); | ||
| } |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.