Create file support #794

jelly · 2024-10-18T07:50:57Z

cockpit-files: File creation support

Files can now create a new file with initial content after creation the dialog changes into editor mode so you can keep editing. When you have "administrative access" the owner of the file is pre-selected based on the owner of the directory so far /home/admin/ it is "admin:admin" and you can also change ownership to root if needed.

src/dialogs/editor.tsx

src/dialogs/create-file.tsx

martinpitt

Thanks!

src/common.ts

martinpitt · 2024-11-04T14:43:57Z

src/common.ts

-import { FileInfo } from "cockpit/fsinfo";
+import { FileInfo } from "cockpit/fsinfo.ts";


I thought specifying extensions was out of fashion? I don't see a build.js or other config change here which could have triggered this?

Honestly I just do what eslint wants, I got a bit tired of the constant churn here.

# /home/jelle/projects/cockpit-files/src/common.ts # 21:26 error Missing file extension "ts" for "cockpit/fsinfo" import/extensions

🤷 no idea why this happens!

src/dialogs/create-file.tsx

martinpitt · 2024-11-04T14:46:04Z

src/dialogs/create-file.tsx

+}
+
+async function create_file(filename: string, content?: string, owner?: string) {
+    // let tag = await read_tag(filename);


Leftover. Perhaps you meant to check here if the file already exists? AFAICS this isn't done anywhere else in the CreateFileModal.

It is on save and once you enter the filename in the TextInput using fsinfo's cwdInfo

src/dialogs/create-file.tsx

martinpitt · 2024-11-04T15:14:18Z

test/check-application

+
+        # Create a file as admin, we are superuser and /home owned by admin
+        b.set_input_text("#file-name", "notes.txt")
+        b.set_input_text(".file-create-modal textarea", "content")


This should validate that the owner select is visible and contains "admin" and "root".

src/dialogs/create-file.tsx

martinpitt · 2024-11-04T15:17:53Z

test/check-application

+        b.set_input_text(".file-create-modal textarea", "content")
+        b.click("button.pf-m-primary")
+
+        b.wait_visible(".file-editor-modal")


Same question as above: Why does this happen? The creation dialog already sets an initial content, why is the user being thrown into the editor dialog here?

test/check-application

martinpitt · 2024-11-04T15:21:28Z

test/check-application

+
+        # Create a file as admin, we are superuser and /home owned by admin
+        b.set_input_text("#file-name", "notes.txt")
+        b.set_input_text(".file-create-modal textarea", "content")


This might be a good place for a pixel test? Everything in the dialog should be predictable, and at this point all the fields are nonempty.

Because Files will gain the ability to create a file and create-item sounds almost like "create file".

The `.file-editor-title-label` class has a workaround for dark mode and the lack of spacing.

This will be re-used in the file creation dialog.

src/dialogs/create-file.tsx

Allow users to create file with initial text and directly start editing. Combining the creation of a file in the editor dialog becomes a stateful mess as the Editor is not really prepared for creating a new file and with our `dialogResult` we can easily make both dialogs appear after each other without race conditions. The fsreplace1 channel does not yet support changing the ownership of a new file so the current files implementation does this using a fsreplace1 to touch a file, chown and then set the contents so the file would never contain contents which another use should not be able to read.

cockpituous · 2024-11-14T10:29:57Z

src/dialogs/create-file.tsx

+    } catch (err) {
+        console.warn("Cannot create new file", err);
+        throw err;


These 3 added lines are not executed by any test.

cockpituous · 2024-11-14T10:29:57Z

src/dialogs/create-file.tsx

+        } catch (err) {
+            console.warn("Cannot chown new file", err);
+            throw err;


These 3 added lines are not executed by any test.

cockpituous · 2024-11-14T10:29:57Z

src/dialogs/create-file.tsx

+                    } catch (err) {
+                        console.warn("Cannot set initial file text", err);
+                        throw err;


These 3 added lines are not executed by any test.

cockpituous · 2024-11-14T10:29:57Z

src/dialogs/create-file.tsx

+    const handleEscape = (event: KeyboardEvent) => {
+        if (filename !== "" || initialText !== "") {
+            event.preventDefault();


These 3 added lines are not executed by any test.

cockpituous · 2024-11-14T10:29:57Z

src/dialogs/create-file.tsx

+        if (filename !== "" || initialText !== "") {
+            event.preventDefault();
+        } else {
+            dialogResult.reject(new Error("no file created"));


This added line is not executed by any test.

cockpituous · 2024-11-14T10:29:58Z

src/dialogs/create-file.tsx

+          position="top"
+          title={_("Create file")}
+          isOpen
+          onClose={() => dialogResult.reject(new Error("no file created"))}


This added line is not executed by any test.

cockpituous · 2024-11-14T10:29:58Z

src/dialogs/create-file.tsx

+                <Alert
+                  className="file-editor-alert"
+                  variant="danger"
+                  title={createError}
+                  isInline


These 5 added lines are not executed by any test.

cockpituous · 2024-11-14T10:29:58Z

src/dialogs/create-file.tsx

+                          isRequired
+                          value={filename}
+                          onChange={(_event, value) => {
+                              setFileNameError(checkFilename(value, cwdInfo?.entries || {}, undefined));


This added line is not executed by any test.

cockpituous · 2024-11-14T10:29:58Z

src/dialogs/rename.tsx

@@ -141,7 +123,7 @@ const RenameItemModal = ({ dialogResult, path, selected } : {
                      if (name !== selected.name)
                          renameItem();
                      else {
-                          setNameError(checkName(name, cwdInfo?.entries || {}, selected));
+                          setNameError(checkFilename(name, cwdInfo?.entries || {}, selected));


This added line is not executed by any test.

cockpituous · 2024-11-14T10:29:58Z

src/dialogs/rename.tsx

@@ -151,7 +133,7 @@ const RenameItemModal = ({ dialogResult, path, selected } : {
                          autoFocus // eslint-disable-line jsx-a11y/no-autofocus
                          value={name}
                          onChange={(_, val) => {
-                              setNameError(checkName(val, cwdInfo?.entries || {}, selected));
+                              setNameError(checkFilename(val, cwdInfo?.entries || {}, selected));


This added line is not executed by any test.

jelly added the no-test label Oct 18, 2024

jelly changed the base branch from create-file to main October 18, 2024 07:53

jelly commented Oct 21, 2024

View reviewed changes

src/dialogs/editor.tsx Outdated Show resolved Hide resolved

jelly commented Oct 21, 2024

View reviewed changes

src/dialogs/editor.tsx Outdated Show resolved Hide resolved

jelly force-pushed the create-file branch from f19c77e to 1aacd96 Compare October 29, 2024 17:21

github-advanced-security bot found potential problems Oct 29, 2024

View reviewed changes

src/dialogs/editor.tsx Fixed Show fixed Hide fixed

jelly force-pushed the create-file branch from 1aacd96 to 2b10da6 Compare October 31, 2024 13:28

github-advanced-security bot found potential problems Oct 31, 2024

View reviewed changes

src/dialogs/create-file.tsx Fixed Show fixed Hide fixed

jelly removed the no-test label Oct 31, 2024

jelly force-pushed the create-file branch from 2b10da6 to 3cf3f3a Compare October 31, 2024 14:43

jelly marked this pull request as ready for review October 31, 2024 14:58

jelly force-pushed the create-file branch from 3cf3f3a to b7fb789 Compare October 31, 2024 17:50

jelly commented Nov 1, 2024

View reviewed changes

src/dialogs/create-file.tsx Outdated Show resolved Hide resolved

jelly force-pushed the create-file branch from b7fb789 to 34d58ac Compare November 1, 2024 09:37

jelly added the release-note label Nov 1, 2024

jelly requested review from martinpitt and tomasmatus November 1, 2024 09:55

jelly changed the title ~~Create file~~ Create file support Nov 1, 2024

martinpitt requested changes Nov 4, 2024

View reviewed changes

jelly force-pushed the create-file branch 3 times, most recently from 15b6d51 to d8db5a3 Compare November 6, 2024 09:23

jelly added 3 commits November 14, 2024 08:52

Rename create-item to create-folder

aa1ca01

Because Files will gain the ability to create a file and create-item sounds almost like "create file".

Remove outdated TODO

8a67256

The `.file-editor-title-label` class has a workaround for dark mode and the lack of spacing.

Make filename rename validation checking re-usable

15c4e25

This will be re-used in the file creation dialog.

jelly force-pushed the create-file branch from d8db5a3 to f37243c Compare November 14, 2024 09:52

github-advanced-security bot found potential problems Nov 14, 2024

View reviewed changes

src/dialogs/create-file.tsx Fixed Show fixed Hide fixed

jelly force-pushed the create-file branch from f37243c to 8ab2c32 Compare November 14, 2024 10:21

cockpituous reviewed Nov 14, 2024

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Create file support #794

Create file support #794

jelly commented Oct 18, 2024 •

edited

Loading

martinpitt left a comment

martinpitt Nov 4, 2024

jelly Nov 4, 2024

jelly Nov 14, 2024

martinpitt Nov 4, 2024

jelly Nov 4, 2024

martinpitt Nov 4, 2024

martinpitt Nov 4, 2024

martinpitt Nov 4, 2024

cockpituous Nov 14, 2024

cockpituous Nov 14, 2024

cockpituous Nov 14, 2024

cockpituous Nov 14, 2024

cockpituous Nov 14, 2024

cockpituous Nov 14, 2024

cockpituous Nov 14, 2024

cockpituous Nov 14, 2024

cockpituous Nov 14, 2024

cockpituous Nov 14, 2024

		import { FileInfo } from "cockpit/fsinfo";
		import { FileInfo } from "cockpit/fsinfo.ts";

Create file support #794

Are you sure you want to change the base?

Create file support #794

Conversation

jelly commented Oct 18, 2024 • edited Loading

cockpit-files: File creation support

martinpitt left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jelly commented Oct 18, 2024 •

edited

Loading