Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: wait on files to load after dropping superuser #831

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

jelly
Copy link
Member

@jelly jelly commented Nov 14, 2024

This part of the test flaked in that it didn't change directory to /etc/. A likely cause is that drop_superuser() does not wait on the page to fully load so the b.go() never registered in cockpit-files.

This part of the test flaked in that it didn't change directory to
/etc/. A likely cause is that drop_superuser() does not wait on the page
to fully load so the `b.go()` never registered in cockpit-files.
@jelly
Copy link
Member Author

jelly commented Nov 14, 2024

No flakes except, sorting. I'll do some thinking on how to solve that one.

@jelly
Copy link
Member Author

jelly commented Nov 14, 2024

        m.execute(f"""
        chmod 6755 {basedir}/eee
        chmod 0755 {basedir}/Eee
        chmod 1700 {basedir}/BBB
        chmod 3700 {basedir}/aaa
        chmod 0701 {basedir}/ccc
        """)

So for the testSorting failure, the screenshot shows a different list then what was checked before. So my reasoning is that we are either missing inotify events or something else?

Copy link
Member

@martinpitt martinpitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cheers! (of course fine to handle testSorting separately)

@jelly jelly merged commit 0d5ac23 into cockpit-project:main Nov 14, 2024
25 checks passed
@jelly jelly deleted the unflake-testeditor branch November 14, 2024 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants