Cockpit 328 #768
Merged
Cockpit 328 #768
+57
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jelly
force-pushed
the
main
branch
2 times, most recently
from
31f191f
to
d898603
Compare
garrett
reviewed
Nov 7, 2024
garrett
reviewed
Nov 7, 2024
garrett
reviewed
Nov 7, 2024
garrett
reviewed
Nov 7, 2024
garrett
requested changes
Nov 7, 2024
There was a problem hiding this comment.
Images are all wrong.
- Every one is oddly cropped.
- The first one is highlighting "Clone" when it's about TPM. It should show the mouseover highlight of TPM, not Clone.
- Second one is a dialog modal, but it doesn't look like that. It's missing the frame (and ideally a shadow)
- Third has the same problem with cropping and doesn't look like a modal.
Please fix the image issues by creating new screenshots.
I've made suggestions to change the text as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://jelly.github.io/cockpit-project.github.io/blog/cockpit-328.html