Skip to content

Commit

Permalink
test: Drop check for sss_ssh_knownhostsproxy --pubkey
Browse files Browse the repository at this point in the history
All our supported images have a recent enough sssd now, so require this
unconditionally.
  • Loading branch information
martinpitt committed Mar 28, 2023
1 parent 9e6a43c commit 93e7dff
Showing 1 changed file with 1 addition and 10 deletions.
11 changes: 1 addition & 10 deletions test/verify/check-system-realms
Original file line number Diff line number Diff line change
Expand Up @@ -580,8 +580,7 @@ class TestIPA(TestRealms, CommonTests):
m.stop_cockpit()
m.start_cockpit()

# check respecting FreeIPA's/sssd's ssh known host keys; this requires the new
# --privkey option of sss_ssh_knownhostproxy, thus only works on recent images
# check respecting FreeIPA's/sssd's ssh known host keys
b.login_and_go("/system", user=f'{self.admin_user}@cockpit.lan', password=self.admin_password)
b.switch_to_top()
b.click("#hosts-sel button")
Expand All @@ -590,10 +589,6 @@ class TestIPA(TestRealms, CommonTests):
b.set_input_text('#add-machine-address', "x0.cockpit.lan")
b.click('#hosts_setup_server_dialog button:contains(Add)')

# with --pubkey support this should Just Work, otherwise confirm fingerprint
if '--pubkey' not in m.execute("sss_ssh_knownhostsproxy --help || true"):
b.wait_in_text('#hosts_setup_server_dialog', "You are connecting to x0.cockpit.lan for the first time.")
b.click('#hosts_setup_server_dialog button:contains(Accept key and connect)')
b.wait_not_present('#hosts_setup_server_dialog')
b.wait_visible("a[href='/@x0.cockpit.lan']")
b.logout()
Expand Down Expand Up @@ -1089,10 +1084,6 @@ class TestKerberos(MachineCase):
b.click("#machine-troubleshoot")
b.wait_visible('#hosts_setup_server_dialog')
b.click('#hosts_setup_server_dialog button:contains(Add)')
# with --pubkey support the fingerprint is already known, otherwise confirm fingerprint
if '--pubkey' not in m.execute("sss_ssh_knownhostsproxy --help || true"):
b.wait_in_text('#hosts_setup_server_dialog', "You are connecting to x0.cockpit.lan for the first time.")
b.click('#hosts_setup_server_dialog button:contains(Accept key and connect)')
b.wait_not_present('#hosts_setup_server_dialog')

b.enter_page("/system/terminal", host="x0.cockpit.lan")
Expand Down

0 comments on commit 93e7dff

Please sign in to comment.