Skip to content

Commit

Permalink
storage: re-enable multi-level compactions
Browse files Browse the repository at this point in the history
The issue of excessively large multi-level compactions was resolved. See
cockroachdb/pebble#3120.

Epic: none
Release note (performance improvement): Enables multi-level compactions which
moderately reduce write amplification within the storage engine.
  • Loading branch information
jbowens committed Sep 25, 2024
1 parent d926d5e commit 66be9b8
Showing 1 changed file with 0 additions and 6 deletions.
6 changes: 0 additions & 6 deletions pkg/storage/pebble.go
Original file line number Diff line number Diff line change
Expand Up @@ -1192,12 +1192,6 @@ func newPebble(ctx context.Context, cfg engineConfig) (p *Pebble, err error) {
// Pebble has better guards against this.
return cfg.sharedStorage != nil || !IngestAsFlushable.Get(&cfg.settings.SV)
}
// Multi-level compactions were discovered to cause excessively large
// compactions that can have adverse affects. We disable these types of
// compactions for now.
// See https://github.com/cockroachdb/pebble/issues/3120
// TODO(travers): Re-enable, once the issues are resolved.
cfg.opts.Experimental.MultiLevelCompactionHeuristic = pebble.NoMultiLevel{}
cfg.opts.Experimental.IngestSplit = func() bool {
return IngestSplitEnabled.Get(&cfg.settings.SV)
}
Expand Down

0 comments on commit 66be9b8

Please sign in to comment.