Skip to content

Commit

Permalink
Merge #135325
Browse files Browse the repository at this point in the history
135325: server: skip TestHotRangesStats under race r=dhartunian a=dhartunian

Resolves: #134144
Resolves: #134946
Resolves: #132219

Release note: None

Co-authored-by: David Hartunian <[email protected]>
  • Loading branch information
craig[bot] and dhartunian committed Nov 15, 2024
2 parents 6da166b + c622e81 commit 6f00e54
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
1 change: 1 addition & 0 deletions pkg/server/structlogging/BUILD.bazel
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ go_test(
"//pkg/sql/catalog/desctestutils",
"//pkg/testutils",
"//pkg/testutils/serverutils",
"//pkg/testutils/skip",
"//pkg/testutils/sqlutils",
"//pkg/testutils/testcluster",
"//pkg/util/leaktest",
Expand Down
3 changes: 3 additions & 0 deletions pkg/server/structlogging/hot_ranges_log_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ import (
"github.com/cockroachdb/cockroach/pkg/sql/catalog/desctestutils"
"github.com/cockroachdb/cockroach/pkg/testutils"
"github.com/cockroachdb/cockroach/pkg/testutils/serverutils"
"github.com/cockroachdb/cockroach/pkg/testutils/skip"
"github.com/cockroachdb/cockroach/pkg/testutils/sqlutils"
"github.com/cockroachdb/cockroach/pkg/util/leaktest"
"github.com/cockroachdb/cockroach/pkg/util/log"
Expand Down Expand Up @@ -80,6 +81,8 @@ func TestHotRangesStats(t *testing.T) {
sc := log.ScopeWithoutShowLogs(t)
defer sc.Close(t)

skip.UnderRace(t)

ctx := context.Background()
spy := hotRangesLogSpy{t: t}
defer log.InterceptWith(ctx, &spy)()
Expand Down

0 comments on commit 6f00e54

Please sign in to comment.