Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
execbuilder: fix nil pointer in tryBuildFastPathInsert
This commit fixes a nil pointer error that we previously would always hit in `tryBuildFastPathInsert` whenever we had a bool value in the VALUES clause. The bug was introduced in d2f48b9 where we added the support for fast path with single row VALUES clauses. The issue is that we ignored the "ok" boolean for the type conversion, which is now fixed by explicitly checking a couple of bool expressions as well as not using the fast path if non-const non-bool expression is present. Release note (bug fix): Previously, CockroachDB would hit an internal error when evaluating INSERTs into REGIONAL BY ROW tables where the source is a VALUES clause with a single row and at least one boolean expression, and this is now fixed. The bug was introduced in 23.2.0 release.
- Loading branch information