Skip to content

Commit

Permalink
Merge pull request #129934 from cockroachdb/blathers/backport-release…
Browse files Browse the repository at this point in the history
…-24.2.1-rc-129802

release-24.2.1-rc: security,jwtauthccl: Fix test failures due to leaked goroutines
  • Loading branch information
pritesh-lahoti authored Sep 3, 2024
2 parents 3680a78 + f98e57a commit b95f17a
Showing 1 changed file with 4 additions and 0 deletions.
4 changes: 4 additions & 0 deletions pkg/util/leaktest/leaktest.go
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,10 @@ func interestingGoroutines() map[int64]string {
strings.Contains(stack, "github.com/jackc/pgconn/internal/ctxwatch.(*ContextWatcher).Watch.func1") ||
// Ignore pq goroutine that watches for context cancellation.
strings.Contains(stack, "github.com/lib/pq.(*conn).watchCancel") ||
// Ignore TLS handshake related goroutine.
// TODO(pritesh-lahoti): Revisit this once Go is updated to 1.23, as this seems to have been
// fixed: https://github.com/golang/go/pull/62227.
strings.Contains(stack, "net/http.(*persistConn).addTLS") ||
// Seems to be gccgo specific.
(runtime.Compiler == "gccgo" && strings.Contains(stack, "testing.T.Parallel")) ||
// Ignore intentionally long-running logging goroutines that live for the
Expand Down

0 comments on commit b95f17a

Please sign in to comment.