Skip to content

Commit

Permalink
Merge #129732
Browse files Browse the repository at this point in the history
129732: dev: also build `ts_project` for `eslint-plugin-crdb` in `gen js` r=koorosh,dhartunian a=rickystewart

Without this, generation can fail with an error like:

```
Rel: can't make  relative to /private/var/tmp/_bazel_davidh/d61affdd093572eb0c41c4220c20a747/execroot/com_github_cockroachdb_cockroach/bazel-out/darwin_arm64-fastbuild/bin/pkg/ui/workspaces/eslint-plugin-crdb/dist
```

It's unclear right now why this is happening. My suspicion is there is some sort of bug or deficiency in `rules_js` and/or `rules_ts` specifically on more recent Bazel versions and is probably related to Bazel 7 being more aggressive about rejecting using directories as output files.

Epic: none

Release note: None
Closes: #129369

Co-authored-by: Ricky Stewart <[email protected]>
  • Loading branch information
craig[bot] and rickystewart committed Sep 19, 2024
2 parents e757626 + 73d7ca2 commit ef01f6d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion pkg/cmd/dev/generate.go
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ func (d *dev) generateJs(cmd *cobra.Command) error {

args := []string{
"build",
"//pkg/ui/workspaces/eslint-plugin-crdb:eslint-plugin-crdb-lib",
"//pkg/ui/workspaces/eslint-plugin-crdb:ts_project",
"//pkg/ui/workspaces/db-console/src/js:crdb-protobuf-client",
"//pkg/ui/workspaces/cluster-ui:ts_project",
}
Expand Down

0 comments on commit ef01f6d

Please sign in to comment.