raft: remove MsgApp flow control management dependence on heartbeats #130532
+723
−277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
iskettaneh
force-pushed
the
RaftProbePaused
branch
2 times, most recently
from
cb77779
to
cd5495d
Compare
iskettaneh
changed the title
iskettaneh
force-pushed
the
RaftProbePaused
branch
from
cd5495d
to
928a16f
Compare
iskettaneh
force-pushed
the
RaftProbePaused
branch
from
928a16f
to
5373f03
Compare
iskettaneh
force-pushed
the
RaftProbePaused
branch
2 times, most recently
from
4b5843e
to
ded0b3f
Compare
This commit does the following: Instead of unpausing the follower and maybe sending a MsgApp when receiving a heartbeat response, it does the same thing but on heartbeat timeout if the follower is supporting the leader. Fixes: cockroachdb#130493 Release note: None
iskettaneh
force-pushed
the
RaftProbePaused
branch
from
ded0b3f
to
3ee9e30
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit does the following:
Instead of unpausing the follower and maybe sending a MsgApp when receiving a heartbeat response, it does the same thing but on heartbeat timeout if the follower is supporting the leader. Otherwise, it sends MsgFortifyLeader to the follower who is not supporting the leader.
This change is guarded by SupportFromEnabled(). If it flips to true, it will stop depending on heartbeat responses. If it flips to false, it will start depending on heartbeat responses again.
NOTE: future PRs will stop heartbeats all together if storeliveness is enabled.
Fixes: #130493
Epic: None
Release note: None