-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
sql: add optional message to CANCEL commands #130776
base: master
Are you sure you want to change the base?
Conversation
Thank you for contributing to CockroachDB. Please ensure you have followed the guidelines for creating a PR. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. I have added a few people who may be able to assist in reviewing: 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
This comment was marked as outdated.
This comment was marked as outdated.
46ba3a9
to
1dfd2db
Compare
Thank you for updating your pull request. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
1dfd2db
to
1831c82
Compare
It looks like your PR touches SQL parser code but doesn't add or edit parser tests. Please make sure you add or edit parser tests if you edit the parser. Thank you for updating your pull request. My owl senses detect your PR is good for review. Please keep an eye out for any test failures in CI. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
Previously, asynchronous CANCEL commands ("CANCEL QUERY", "CANCEL SESSION") didn't provide much information back to the query/session being canceled. This commit addresses this issue by: - Update the SQL syntax of "CANCEL" commands ("CANCEL QUERY", "CANCEL SESSION") to add a new "WITH MESSAGE <message>" clause. - The canceled query/session will throw an error with the <message> from the canceler. Fixes: cockroachdb#127490 Release note (sql change): Add optional "WITH MESSAGE <message>" clause to CANCEL commands, providing more detailed information when a query is canceled.
1831c82
to
4a5d505
Compare
hi, @michae2 |
overview
Previously, asynchronous CANCEL commands ("CANCEL QUERY", "CANCEL SESSION") didn't provide much information back to the query/session being canceled.
This commit addresses this issue by:
Fixes: #127490
Release note (sql change): Add optional "WITH MESSAGE " clause to CANCEL commands, providing more detailed information when a query is canceled.
sql syntax changes
how to review
Other changes are trivial.
concerns
todo