crosscluster/logical: add SKIP SCHEMA CHECK option #131090
Conversation
PR cockroachdb#130905 added several checks to LDR stream planning to ensure a bidrectional stream will suceed. A user may want to skip the table equivalency checks (e.g. all constraints are matching) if they are running a unidirectional stream or if they simply want to live life on the edge. Epic: none Release note: none
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
It looks like your PR touches SQL parser code but doesn't add or edit parser tests. Please make sure you add or edit parser tests if you edit the parser. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @azhu-crl, @dt, @msbutler, and @stevendanna)
pkg/sql/catalog/tabledesc/logical_replication_helpers.go line 35 at r1 (raw file):
return pgerror.Wrapf(err, pgcode.InvalidTableDefinition, cannotLDRMsg) } }
Do we want to throw a pgnotice just incase when the check is skipped?
There was a problem hiding this comment.
Reviewable status:
pkg/sql/catalog/tabledesc/logical_replication_helpers.go line 35 at r1 (raw file):
Previously, fqazi (Faizan Qazi) wrote…
Do we want to throw a pgnotice just incase when the check is skipped?
i don't think we need to. they are explicitly asking us to skip the check with the SKIP SCHEMA CHECK option.
There was a problem hiding this comment.
Reviewable status:
pkg/sql/catalog/tabledesc/logical_replication_helpers.go line 35 at r1 (raw file):
Previously, msbutler (Michael Butler) wrote…
i don't think we need to. they are explicitly asking us to skip the check with the
SKIP SCHEMA CHECKoption.
Fair
|
bors r+ |
PR #130905 added several checks to LDR stream planning to ensure a bidrectional stream will suceed. A user may want to skip the table equivalency checks (e.g. all constraints are matching) if they are running a unidirectional stream or if they simply want to live life on the edge.
Epic: none
Release note: none