release-24.2: roachtest: don't report VM preemptions on github #131091
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![blathers-crl[bot]](https://avatars.githubusercontent.com/in/59700?s=60&v=4){kind=small}
`shouldPost` used to return `(bool, string)` but, in reality, the bool value just encoded the whether the returned string was empty. Simplify that function by returning a single value and having callers be explicit about checking the skip reason. Epic: none Release note: None
`registry.NonReportableError` can be used in situations where an error happens in a test but we do not want to create (or update) a GitHub issue for it. The mechanism introduced here can be used either in the test runner, or in tests themselves. For now, they are only used when a VM is preempted. We have enabled spot VMs with a higher probability and backported this behaviour to several release branches. It's not really useful or actionable to have a GitHub issue for every preemption. Instead, this kind of data is better analyzed at a higher level, on an analytical database, using dashboards. Epic: none Release note: None
blathers-crl
bot
force-pushed
the
blathers/backport-release-24.2-130976
branch
from
350691b
to
ae19630
Compare
blathers-crl
bot
added
blathers-backport
blathers-crl
bot
requested review from
DarrylWong,
renatolabs,
herkolategan,
nameisbhaskar and
vidit-bhat
and removed request for
a team
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
blathers-crl
bot
added
the
backport
|
This change is |
srosenberg
approved these changes
Sep 20, 2024
|
TFTR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport 2/2 commits from #130976 on behalf of @renatolabs.
/cc @cockroachdb/release
The new
registry.NonReportableErrorcan be used in situations where an errorhappens in a test but we do not want to create (or update) a GitHub
issue for it. The mechanism introduced here can be used either in the
test runner, or in tests themselves. For now, they are only used when
a VM is preempted.
We have enabled spot VMs with a higher probability and backported this
behaviour to several release branches. It's not really useful or
actionable to have a GitHub issue for every preemption. Instead, this
kind of data is better analyzed at a higher level, on an analytical
database, using dashboards.
Epic: none
Release note: None
Release justification: test only changes.