Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: disable checkUncertainty on failOnMoreRecent in scanner #131093

Merged
merged 2 commits into from
Sep 26, 2024
Merged

storage: disable checkUncertainty on failOnMoreRecent in scanner #131093

merged 2 commits into from
Sep 26, 2024

Commits on Sep 25, 2024

  1. storage: test combined failOnMoreRecent and uncertainty error 

    Epic: none
Release note: None
    @tbg
    tbg committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    2d49f18 View commit details
    Browse the repository at this point in the history

  2. storage: disable checkUncertainty on failOnMoreRecent in scanner 

    It was possible for reads with failOnMoreRecent to hit a
ReadWithinUncertaintyIntervalError instead of the desired
WriteTooOldError. This commit disables uncertainty checks when
failOnMoreRecent is active, as the latter is a stronger check anyway.

Fixes cockroachdb#119681.
Fixes cockroachdb#131005.

Epic: none
Release note: None
    @tbg
    tbg committed Sep 25, 2024
    Configuration menu
    Copy the full SHA
    10664ba View commit details
    Browse the repository at this point in the history