cluster-ui: add getTableMetadataApi and connect tables page #131123
Conversation
xinhaoz
requested review from
angles-n-daemons,
dhartunian and
kyle-a-wong
and removed request for
a team
|
This change is |
xinhaoz
force-pushed
the
connect-tables-v2
branch
2 times, most recently
from
8183448
to
528111f
Compare
|
https://www.loom.com/share/9d9ab55daa484920851e8377d5bcca0c Note that the percentage live data column has a bug in that video that is fixed in #131124 |
| percent_live_data: number; | ||
| total_live_data_bytes: number; | ||
| total_data_bytes: number; | ||
| store_ids: number[] | null; |
There was a problem hiding this comment.
is this nullable / Are you seeing cases where this is null instead of an empty array?
There was a problem hiding this comment.
Ah I just saw that the system schema defines this column as not nullable. Removed.
| dbID?: number; | ||
| sortBy?: string; | ||
| sortOrder?: "asc" | "desc"; | ||
| storeID?: StoreID[]; |
There was a problem hiding this comment.
nit: should this be storeIds? Also same comment about the the capital D
| type TableMetadataResponse = APIV2ResponseWithPaginationState<TableMetadata[]>; | ||
|
|
||
| export type TableMetadataRequest = { | ||
| dbID?: number; |
There was a problem hiding this comment.
nit: I know this is pretty inconsistent in the repo, but I think I personally don't think the "D" in "ID" should be uppercase
| <div> | ||
| {Bytes(t.liveDataBytes)} / {Bytes(t.totalDataBytes)} | ||
| <div>{t.liveDataPercentage * 100}%</div> |
There was a problem hiding this comment.
nit: We should maybe talk to Inna about what level of precision we want and should round to that. Also one thing about rounding logic that we should keep in mind is that we shouldnt round "99.99x" up to 100%
There was a problem hiding this comment.
Ack - yeah let's get her to review and leave design requests.
xinhaoz
force-pushed
the
connect-tables-v2
branch
from
528111f
to
5cebce1
Compare
This commit connects the v2 db details - tables page to the new `api/v2/table_metadata` api route. The following components are now connected to the api: - listing tables for a db - sorting by column - searching by table name - filtering by node id Epic: CRDB-37558 Fixes: cockroachdb#131122 Release note: None
xinhaoz
force-pushed
the
connect-tables-v2
branch
from
5cebce1
to
47dfdab
Compare
|
TFTR! |
Only the latest commit should be reviewed in this PR.
Previous: #131046
This commit connects the v2 db details - tables page to the
new
api/v2/table_metadataapi route.The following components are now connected to the api:
Epic: CRDB-37558
Fixes: #131122
Release note: None