sql: make hba_conf and id_map cluster settings sensitive #131150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fixes cockroachdb#129126 fixes CRDB-41389 Epic CRDB-33829 Release note(security, ops): Cluster settings for host based authentication configuration (`server.host_based_authentication.configuration`) and identity map configuration(`server.identity_map.configuration`) need to be redacted as they can be configured to contain LDAP bind usernames, passwords and mapping of external identities to sql users which are sensitive and should be configurable for redaction via `server.redact_sensitive_settings.enabled` cluster setting.
|
This change is |
pritesh-lahoti
approved these changes
Sep 23, 2024
There was a problem hiding this comment.
Reviewed 5 of 5 files at r1, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @rafiss)
|
Thank you for the review! bors r=pritesh-lahoti |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #129126
fixes CRDB-41389
Epic CRDB-33829
Release note(security, ops): Cluster settings for host based authentication configuration (
server.host_based_authentication.configuration) and identity map configuration(server.identity_map.configuration) need to be redacted as they can be configured to contain LDAP bind usernames, passwords and mapping of external identities to sql users which are sensitive and should be configurable for redaction viaserver.redact_sensitive_settings.enabledcluster setting.