Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ldapccl: fix LDAP cluster settings callback #131151

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

souravcrl
Copy link
Contributor

ldapccl: fix LDAP cluster settings callback

Epic CRDB-33829

Release note(security, ops): Cluster settings for LDAP cluster settings server.ldap_authentication.client.tls_certificate and server.ldap_authentication.client.tls_key don't have callbacks installed to reload the settings value for LDAP authManager. This change fixes this by adding the necessary callbacks.

Epic CRDB-33829

Release note(security, ops): Cluster settings for LDAP cluster settings
`server.ldap_authentication.client.tls_certificate` and
`server.ldap_authentication.client.tls_key` don't have callbacks installed to
reload the settings value for LDAP authManager. This change fixes this by adding
the necessary callbacks.
Copy link

blathers-crl bot commented Sep 21, 2024

It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR?

🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

@cockroach-teamcity
Copy link
Member

This change is Reviewable

@souravcrl souravcrl added the backport-24.1.x Flags PRs that need to be backported to 24.1. label Sep 21, 2024
@souravcrl souravcrl self-assigned this Sep 21, 2024
@souravcrl souravcrl added backport-24.2.x Flags PRs that need to be backported to 24.2 and removed backport-24.1.x Flags PRs that need to be backported to 24.1. labels Sep 21, 2024
@souravcrl souravcrl marked this pull request as ready for review September 23, 2024 05:01
@souravcrl souravcrl requested review from a team as code owners September 23, 2024 05:01
Copy link
Contributor

@pritesh-lahoti pritesh-lahoti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @souravcrl)

Copy link
Collaborator

@sanchit-CRL sanchit-CRL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: :shipit: complete! 0 of 0 LGTMs obtained (waiting on @souravcrl)

@souravcrl
Copy link
Contributor Author

TFTR !

bors r=pritesh-lahoti,sanchit-CRL

@craig craig bot merged commit fa1cd33 into cockroachdb:master Sep 23, 2024
23 checks passed
Copy link

blathers-crl bot commented Sep 23, 2024

Encountered an error creating backports. Some common things that can go wrong:

  1. The backport branch might have already existed.
  2. There was a merge conflict.
  3. The backport branch contained merge commits.

You might need to create your backport manually using the backport tool.


error creating merge commit from d918f38 to blathers/backport-release-24.2-131151: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict []

you may need to manually resolve merge conflicts with the backport tool.

Backport to branch 24.2.x failed. See errors above.


🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-24.2.x Flags PRs that need to be backported to 24.2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants