-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ldapccl: fix LDAP cluster settings callback #131151
ldapccl: fix LDAP cluster settings callback #131151
Conversation
Epic CRDB-33829 Release note(security, ops): Cluster settings for LDAP cluster settings `server.ldap_authentication.client.tls_certificate` and `server.ldap_authentication.client.tls_key` don't have callbacks installed to reload the settings value for LDAP authManager. This change fixes this by adding the necessary callbacks.
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @souravcrl)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r1, all commit messages.
Reviewable status: complete! 0 of 0 LGTMs obtained (waiting on @souravcrl)
TFTR ! bors r=pritesh-lahoti,sanchit-CRL |
Encountered an error creating backports. Some common things that can go wrong:
You might need to create your backport manually using the backport tool. error creating merge commit from d918f38 to blathers/backport-release-24.2-131151: POST https://api.github.com/repos/cockroachdb/cockroach/merges: 409 Merge conflict [] you may need to manually resolve merge conflicts with the backport tool. Backport to branch 24.2.x failed. See errors above. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
ldapccl: fix LDAP cluster settings callback
Epic CRDB-33829
Release note(security, ops): Cluster settings for LDAP cluster settings
server.ldap_authentication.client.tls_certificate
andserver.ldap_authentication.client.tls_key
don't have callbacks installed to reload the settings value for LDAP authManager. This change fixes this by adding the necessary callbacks.