Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cloud/amazon: test kms against mock server #131172

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Conversation

dt
Copy link
Member

@dt dt commented Sep 22, 2024

Release note: none.
Epic: none.

@dt dt requested a review from msbutler September 22, 2024 19:17
@dt dt requested a review from a team as a code owner September 22, 2024 19:17
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Release note: none.
Epic: none.
Copy link
Collaborator

@msbutler msbutler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

pkg/cloud/amazon/aws_kms_test.go Show resolved Hide resolved
pkg/cloud/amazon/aws_kms_test.go Show resolved Hide resolved
pkg/cloud/amazon/aws_kms_test.go Show resolved Hide resolved
pkg/cloud/amazon/aws_kms_test.go Show resolved Hide resolved
@dt
Copy link
Member Author

dt commented Sep 23, 2024

TFTR!

bors r+

@craig craig bot merged commit 0b4b121 into cockroachdb:master Sep 23, 2024
23 checks passed
@dt dt deleted the kms-test branch September 23, 2024 16:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants