Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

release-24.2: cloud/amazon: obey endpoint/http client when using implicit auth #131173

Merged
merged 1 commit into from
Sep 23, 2024

Conversation

dt
Copy link
Member

@dt dt commented Sep 22, 2024

Release note (bug fix): The AWS endpoint and cloud custom HTTP client configuration are now considered when implicit authentication is used, whereas previously these were only considered when using explicit credentials.

Epic: none.

Release justification: bug fix.

@dt dt requested a review from msbutler September 22, 2024 20:53
@dt dt requested a review from a team as a code owner September 22, 2024 20:53
Copy link

blathers-crl bot commented Sep 22, 2024

Thanks for opening a backport.

Please check the backport criteria before merging:

  • Backports should only be created for serious
    issues
    or test-only changes.
  • Backports should not break backwards-compatibility.
  • Backports should change as little code as possible.
  • Backports should not change on-disk formats or node communication protocols.
  • Backports should not add new functionality (except as defined
    here).
  • Backports must not add, edit, or otherwise modify cluster versions; or add version gates.
  • All backports must be reviewed by the owning areas TL. For more information as to how that review should be conducted, please consult the backport
    policy
    .
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
  • There is a high priority need for the functionality that cannot wait until the next release and is difficult to address in another way.
  • The new functionality is additive-only and only runs for clusters which have specifically “opted in” to it (e.g. by a cluster setting).
  • New code is protected by a conditional check that is trivial to verify and ensures that it only runs for opt-in clusters. State changes must be further protected such that nodes running old binaries will not be negatively impacted by the new state (with a mixed version test added).
  • The PM and TL on the team that owns the changed code have signed off that the change obeys the above rules.
  • Your backport must be accompanied by a post to the appropriate Slack
    channel (#db-backports-point-releases or #db-backports-XX-X-release) for awareness and discussion.

Also, please add a brief release justification to the body of your PR to justify this
backport.

@blathers-crl blathers-crl bot added the backport Label PR's that are backports to older release branches label Sep 22, 2024
@cockroach-teamcity
Copy link
Member

This change is Reviewable

Release note (bug fix): The AWS endpoint and cloud custom HTTP client
configuration are now considered when implicit authentication is used,
whereas previously these were only considered when using explicit credentials.

Epic: none.
@msbutler msbutler merged commit e875d80 into cockroachdb:release-24.2 Sep 23, 2024
19 of 20 checks passed
@dt
Copy link
Member Author

dt commented Sep 23, 2024

blathers backport 23.1
blathers backport 23.2
blathers backport 24.1

@dt
Copy link
Member Author

dt commented Sep 23, 2024

blathers backport 23.2

@dt
Copy link
Member Author

dt commented Sep 23, 2024

blathers backport 24.1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Label PR's that are backports to older release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants