Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

storage: set correct key in WriteTooOld error from pebbleMVCCScanner #131220

Merged
merged 1 commit into from
Sep 25, 2024

Commits on Sep 23, 2024

  1. storage: set correct key in WriteTooOld error from pebbleMVCCScanner

    Noticed while reviewing cockroachdb#131093.
    
    This commit fixes pebbleMVCCScanner to set the correct key for the
    mostRecentKey field when a locking read encounters multiple keys with
    more recent timestamps. These keys were added to WriteTooOld error in
    52c6b1b, which had previously only been carrying the maximum
    conflicting timestamp. They are currently only used for debugging.
    
    Before this fix, we would always return the first conflicting key, even
    though we correctly returned the maximum conflicting timestamp.
    
    Epic: None
    Release note: None
    nvanbenschoten committed Sep 23, 2024
    Configuration menu
    Copy the full SHA
    6a935de View commit details
    Browse the repository at this point in the history