-
Notifications
You must be signed in to change notification settings - Fork 3.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
release-23.2: admission: lock work queue before reading waiting length #131292
Conversation
When replicated work is submitted for admission, it returns early and admission proceeds asynchronously to the caller. When `V(1)` is enabled, we also log the current queue length in this code path, which is protected by a mutex that wasn't acquired previously. Acquire the queue mutex when `V(1)` is enabled to prevent a race. Part of: #130187 Release note: None
8bfc279
to
db76b95
Compare
Thanks for opening a backport. Please check the backport criteria before merging:
If your backport adds new functionality, please ensure that the following additional criteria are satisfied:
Also, please add a brief release justification to the body of your PR to justify this |
It looks like your PR touches production code but doesn't add or edit any test code. Did you consider adding tests to your PR? 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewable status: complete! 1 of 0 LGTMs obtained (waiting on @kvoli and @pav-kv)
TYFTR, extended CI looks unrelated. |
Backport 1/1 commits from #131109 on behalf of @kvoli.
/cc @cockroachdb/release
When replicated work is submitted for admission, it returns early and
admission proceeds asynchronously to the caller. When
V(1)
is enabled,we also log the current queue length in this code path, which is
protected by a mutex that wasn't acquired previously.
Acquire the queue mutex when
V(1)
is enabled to prevent a race.Part of: #130187
Release note: None
Release justification: Race condition fix.