roachtest: add admission control variations to test #135024
Conversation
![blathers[crl]](https://avatars.githubusercontent.com/in/59700?s=40&u=373d9101a12edc3847d2fb6ae78e3adcfb4ca41e&v=4){kind=avatar}
|
Your pull request contains more than 1000 changes. It is strongly encouraged to split big PRs into smaller chunks. 🦉 Hoot! I am a Blathers, a bot for CockroachDB. My owner is dev-inf. |
|
This change is |
andrewbaptist
force-pushed
the
2024-11-12-apply-all-option
branch
3 times, most recently
from
eefdf7c
to
2c26fc6
Compare
andrewbaptist
requested review from
herkolategan and
srosenberg
and removed request for
a team
There was a problem hiding this comment.
Reviewed 1 of 1 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status:complete! 0 of 0 LGTMs obtained (waiting on @andrewbaptist, @herkolategan, and @srosenberg)
-- commits line 2 at r1:
Specify the perturbation package.
-- commits line 4 at r1:
Likewise here.
pkg/cmd/roachtest/tests/perturbation/framework.go line 170 at r1 (raw file):
case elasticOnlyBoth: return map[string]string{ "admission.kv.bulk_only.enabled": "true",
What is bulk_only for? Are we intending to run it automatically via CI? Generally, I was thinking of something much simpler here, just apply_to_elastic and apply_to_all.
pkg/cmd/roachtest/tests/perturbation/framework.go line 281 at r1 (raw file):
// finish completes initialization of the variations. func (v variations) finish() variations {
nit: finishing the setup might be better named finishSetup, or completeSetup.
andrewbaptist
force-pushed
the
2024-11-12-apply-all-option
branch
3 times, most recently
from
c1b02ac
to
c1fec0e
Compare
There was a problem hiding this comment.
TFTR! changes made!
Reviewable status:
Previously, kvoli (Austen) wrote…
Specify the perturbation package.
Done
Previously, kvoli (Austen) wrote…
Likewise here.
Done
pkg/cmd/roachtest/tests/perturbation/framework.go line 170 at r1 (raw file):
Previously, kvoli (Austen) wrote…
What is
bulk_onlyfor? Are we intending to run it automatically via CI? Generally, I was thinking of something much simpler here, just apply_to_elastic and apply_to_all.
The options above admissionControlOptions are the three modes we will run in metamorphic tests. We have a number of customers still running with bulk only mode and it is useful to make sure we don't break that. I think we can remove that in the future once we roll out apply to all as the default, but its useful to have this as a test for now.
pkg/cmd/roachtest/tests/perturbation/framework.go line 281 at r1 (raw file):
Previously, kvoli (Austen) wrote…
nit: finishing the setup might be better named
finishSetup, orcompleteSetup.
Changed to finishSetup. I also cleaned up the code to correctly return an error if the env variable is set, but the option isn't correctly named.
andrewbaptist
force-pushed
the
2024-11-12-apply-all-option
branch
from
c1fec0e
to
3bccf93
Compare
It is useful to know what cluster settings are being applied in the tests. This change logs them before applying them. Epic: none Release note: None
This commit creates a finishSetup method which is called at the end of the setup phase of perturbation tests. The method can be used to do any application of variables at the end of the test. Epic: none Release note: None
Add options to specify different admission control modes to the perturbation variations. This only impacts the perturbation/metamorphic/* variations, however it allows running the other tests with different AC modes. Fixes: cockroachdb#133412 Release note: None
Allow the user to override perturbations by specifying the environment variable `PERTURBATION_OVERRIDE`. This applies to all perturbation tests, but is useful for reproducing specific metamorphic failures where it is unclear which parameter change caused the difference. An example of using an override to modify the test block size: ``` PERTURBATION_OVERRIDE=blockSize=1024 roachtest run perturbation/full/addNode ``` Epic: none Release note: None
andrewbaptist
force-pushed
the
2024-11-12-apply-all-option
branch
from
3bccf93
to
62303c3
Compare
|
TFTR! We'll starting geting metamorphic variations for apply_to_all this weekend. bors r=kvoli |
Add options to specify different admission control modes to the variations.
Fixes: #133412
Release note: None