sql: audit error creation during planning #135027
Merged
+169
−134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit audits error creation during the execution planning state (mostly for vectorized engine) to avoid retrieving the stack trace when creating errors on the hot paths. We do so by only wrapping or creating fresh errors when "expensive log is enabled" (so that the detailed errors showed up in trace) and otherwise using the provided or a global error. In many places I also substitued miscellaneous calls to `AssertionFailedf` where I thought we'd be getting into an invalid state, to make it more clear. Release note: None
|
This change is |
DrewKimball
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Reviewed 60 of 60 files at r1, all commit messages.
Reviewable status:complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)
mgartner
approved these changes
Nov 13, 2024
There was a problem hiding this comment.
Reviewed 60 of 60 files at r1, all commit messages.
Reviewable status:
|
TFTRs! bors r+ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit audits error creation during the execution planning phase (mostly for vectorized engine) to avoid retrieving the stack trace when creating errors on the hot path. We do so by only wrapping or creating fresh errors when "expensive log is enabled" (so that the detailed errors still show up in trace) and otherwise using the provided or a global error. In many places I also substituted miscellaneous calls to
AssertionFailedfwhere I thought we'd be getting into an invalid state, to make it more clear.Fixes: #134586.
Release note: None