go.mod: bump Pebble to 8e01ef310206 #135033
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Changes: * [`8e01ef31`](cockroachdb/pebble@8e01ef31) sstable: order range keys consistently in colblk and rowblk encodings * [`048f2756`](cockroachdb/pebble@048f2756) table cache: use a long-lived ReaderProvider * [`9f68a214`](cockroachdb/pebble@9f68a214) table cache: include tableCacheNode, tableCacheValue in size metric * [`a5939f4d`](cockroachdb/pebble@a5939f4d) cache: misc tiny cleanups Release note: none. Epic: none.
|
This change is |
|
TFTR! bors r=itsbilal |
craig bot
pushed a commit
that referenced
this pull request
Nov 13, 2024
134501: kvserver: use scratch range in BenchmarkStoreRangeSplit r=miraradeva a=stevendanna When investigating a potential regression in this microbench mark, we observed that merging timeseries data during stats calculation accounted for a good deal of the allocations and runtime. While we should certainly optimize timeseries handling, it raises the question: why was this benchmark encountering so many timeseries values? This benchmark is repeatedly splitting and merging a range. In the old test, it was always splitting range 1 which includes all of the system keys and the tsdb. Now, we do this splitting and merging on a scratch range. This is still pretty noisy, but I hope this change will make it easier to hunt down regressions in split itself. Epic: none Release note: None 135033: go.mod: bump Pebble to 8e01ef310206 r=itsbilal a=jbowens Changes: * [`8e01ef31`](cockroachdb/pebble@8e01ef31) sstable: order range keys consistently in colblk and rowblk encodings * [`048f2756`](cockroachdb/pebble@048f2756) table cache: use a long-lived ReaderProvider * [`9f68a214`](cockroachdb/pebble@9f68a214) table cache: include tableCacheNode, tableCacheValue in size metric * [`a5939f4d`](cockroachdb/pebble@a5939f4d) cache: misc tiny cleanups Release note: none. Epic: none. Co-authored-by: Steven Danna <[email protected]> Co-authored-by: Jackson Owens <[email protected]>
|
Build failed (retrying...): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes:
8e01ef31sstable: order range keys consistently in colblk and rowblk encodings048f2756table cache: use a long-lived ReaderProvider9f68a214table cache: include tableCacheNode, tableCacheValue in size metrica5939f4dcache: misc tiny cleanupsRelease note: none.
Epic: none.