Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sql: use test rand in tests #135040

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Conversation

yuzefovich
Copy link
Member

This should make tests more deterministic.

Informs: #134742.
Epic: None

Release note: None

@yuzefovich yuzefovich requested review from a team as code owners November 12, 2024 23:36
@yuzefovich yuzefovich requested review from rytaft and removed request for a team November 12, 2024 23:36
@cockroach-teamcity
Copy link
Member

This change is Reviewable

This should make tests more deterministic.

Release note: None
Copy link
Collaborator

@rytaft rytaft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm: thank you!

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: :shipit: complete! 1 of 0 LGTMs obtained (waiting on @yuzefovich)

Copy link
Collaborator

@mgartner mgartner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:lgtm:

Reviewed 10 of 10 files at r1, all commit messages.
Reviewable status: :shipit: complete! 2 of 0 LGTMs obtained (waiting on @yuzefovich)

@yuzefovich
Copy link
Member Author

TFTRs!

bors r+

@craig craig bot merged commit 2c18247 into cockroachdb:master Nov 13, 2024
22 of 23 checks passed
@yuzefovich yuzefovich deleted the deterministic-tests branch November 13, 2024 18:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants