server: refactor TestSpanStatsFanOutFaultTolerance #135323
Open
+16
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No need to run this under stress or race since it's testing a manually constructed failure scenario. Fixed incorrect `t` being used in test validations which would mask which subtest was failing. Added more logging to test cases that have failed before. Resolves: cockroachdb#128750 Resolves: cockroachdb#131082 Release note: None
dhartunian
added
backport-24.2.x
dhartunian
requested review from
angles-n-daemons
and removed request for
a team
|
This change is |
kyle-a-wong
approved these changes
Nov 15, 2024
Comment on lines
+409
to
+410
| skip.UnderStress(t) | ||
| skip.UnderRace(t) |
There was a problem hiding this comment.
nit: there is also skip.UnderDuress() which includes syncutil.DeadlockEnabled. Not sure if you want to skip under deadlock too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No need to run this under stress or race since it's testing a manually constructed failure scenario.
Fixed incorrect
tbeing used in test validations which would mask which subtest was failing.Added more logging to test cases that have failed before.
Resolves: #128750
Resolves: #131082
Release note: None