kvserver/rangefeed: add UpdateMetricsOnRangefeedDisconnectBy #135330
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change is |
This patch updates RangefeedMetricsRecorder to include UpdateMetricsOnRangefeedDisconnectBy, which decrements rangefeed metrics by the given argument. While the benefits remain unclear, future commits will use this method to clean up metrics during multiple rangefeed disconnects. Epic: none Release note: none
wenyihu6
force-pushed
the
supportmult
branch
from
6afae33
to
6db61ed
Compare
|
Closing - a separate pr doesn't seem necessary. i trust that we can get this in with https://github.com/cockroachdb/cockroach/pull/134958/commits. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch updates RangefeedMetricsRecorder to include
UpdateMetricsOnRangefeedDisconnectBy, which decrements rangefeed metrics by the
given argument.
Epic: none
Release note: none